Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more explicit about assocComp()$association meaning #250

Open
alexg9010 opened this issue Feb 18, 2022 · 0 comments
Open

Be more explicit about assocComp()$association meaning #250

alexg9010 opened this issue Feb 18, 2022 · 0 comments
Labels

Comments

@alexg9010
Copy link
Collaborator

When talking about the batch correction (

We have implemented some rudimentary functionality for batch effect control. You
can check which one of the principal components are statistically associated
with the potential batch effects such as batch processing dates, age of
subjects, sex of subjects using `assocComp`. The function gets principal
components from the percent methylation matrix derived from the input
`methylBase` object, and checks for association. The tests for association are
either via Kruskal-Wallis test or Wilcoxon test for categorical attributes and
correlation test for numerical attributes for samples such as age. If you are
convinced that some principal components are accounting for batch effects, you
can remove those principal components from your data using `removeComp`.
), we should probably be more explicit about the output of assocComp() (

methylKit/R/batchControl.R

Lines 180 to 185 in ab60a62

#' @return a named list of principal component matrix (named 'pcs'),
#' % variation explained
#' by principal compopents (named 'vars') and a p-value matrix
#' showing association
#' p-values between sample annotations and principal components
#' (named 'association').
).

This recent issue (#247 ) shows that people might not be aware that the association component contains p-values, thus should not be interpreted as percentages of association or similar.

I suggest renaming the list item to something more explicit, like association_test or association_pval.

@alexg9010 alexg9010 changed the title Be more explicit about assoccomp()$association meaning Be more explicit about assocComp()$association meaning Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant