New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we continue to disallow nans in predictions? #71

Open

phinate opened this issue Sep 26, 2024 · 0 comments

Collaborator

phinate commented Sep 26, 2024

cloudcasting/src/cloudcasting/models.py

Lines 41 to 43 in d84dde0

    
           if np.isnan(y_hat).any(): 
        
               msg = f"Predictions contain NaNs: {np.isnan(y_hat).mean()=:.4g}." 
        
               raise ValueError(msg)

Not fully convinced we need this now that our metrics handle NaNs gracefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment