Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blob storage logs #2309

Closed
Tracked by #1922
JimMadge opened this issue Nov 26, 2024 · 4 comments · Fixed by #2310
Closed
Tracked by #1922

Add blob storage logs #2309

JimMadge opened this issue Nov 26, 2024 · 4 comments · Fixed by #2310
Assignees

Comments

@JimMadge
Copy link
Member

Part of #1922

@JimMadge JimMadge self-assigned this Nov 26, 2024
@github-project-automation github-project-automation bot moved this to To Be Refined in Data Safe Haven Nov 26, 2024
@JimMadge JimMadge moved this from To Be Refined to In progress in Data Safe Haven Nov 26, 2024
This was referenced Nov 26, 2024
@JimMadge
Copy link
Member Author

Easy to set up in the portal.

Having a little trouble getting the resource uri for the diagnostic setting correct in Pulumi.
It seems that the diagnostic setting we want doesn't apply to either the storage account or blob container.
Instead, it belongs to the blobServices of the storage account.

(Storage accounts do support diagnostic settings but they only have metrics, not logs on data events).

@craddm
Copy link
Contributor

craddm commented Nov 26, 2024

Had that same problem - resource_uri=props.storage_account_id.apply(lambda v: f"{v}/blobServices/default") fixed it. Need the /default on the end.

@JimMadge
Copy link
Member Author

@craddm Yeah, that looked to be the URI. I think I tried that and it didn't work but I'll have another look.

Where did you use that?

@JimMadge
Copy link
Member Author

@craddm That was right 🎉!
The error I had was because I had deployed a diagnostic setting in the portal to test which conflicted with what I had put in Pulumi.

Thanks for the nudge or I might have not noticed 👍.

@JimMadge JimMadge moved this from In progress to In review in Data Safe Haven Nov 29, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in Data Safe Haven Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants