Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ingest logs for blob containers #2310

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Ingest logs for blob containers #2310

wants to merge 8 commits into from
+246 −108

Conversation

JimMadge
Copy link
Member

@JimMadge JimMadge commented Nov 26, 2024 •
edited
Loading

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

🚦 Depends on

⤴️ Summary

🌂 Related issues

Closes #2309
Contributes to #1922

🔬 Tests

Tested on a new SRE deployment

Screenshot 2024-11-28 at 13 45 01

@craddm
Copy link
Contributor

craddm commented Nov 26, 2024 •
edited
Loading

I did actually make a start on this earlier https://github.com/craddm/data-safe-haven/tree/add-storage-logging - but didn't get very far before having to work on something else

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 26, 2024 •
edited
Loading

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  data_safe_haven/infrastructure/components/composite
  __init__.py
  nfsv3_blob_container.py
  nfsv3_storage_account.py 24-30, 53-144
  data_safe_haven/infrastructure/components/wrapped
  __init__.py
  data_safe_haven/infrastructure/programs
  declarative_sre.py 202
  data_safe_haven/infrastructure/programs/sre
  data.py 75, 474, 491
  desired_state.py 79, 109, 125
Project Total  

This report was generated by python-coverage-comment-action

@JimMadge JimMadge marked this pull request as ready for review November 28, 2024 14:02
@JimMadge JimMadge requested review from a team as code owners November 28, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add blob storage logs
2 participants
@JimMadge @craddm