Raise ValueError if acquisition fn doesn't set min_or_max attr

Author: tom-andersson

deepsensor/active_learning/algorithms.py

@@ -414,6 +414,10 @@ def __call__(
             )
 
         self.min_or_max = acquisition_fn.min_or_max
+        if self.min_or_max not in ["min", "max"]:
+            raise ValueError(
+                f"min_or_max must be either 'min' or 'max', got {self.min_or_max}."
+            )
 
         if isinstance(tasks, Task):
             tasks = [tasks]

tests/test_active_learning.py

@@ -15,7 +15,7 @@
     OracleMAE,
     OracleRMSE,
     OracleMarginalNLL,
-    OracleJointNLL,
+    OracleJointNLL, AcquisitionFunction,
 )
 from deepsensor.active_learning.algorithms import GreedyAlgorithm
 
@@ -258,3 +258,23 @@ def test_greedy_alg_with_oracle_acquisition_fn_without_task_loader_raises_value_
 
         with self.assertRaises(ValueError):
             _ = alg(acquisition_fn, task)
+
+    def assert_acquisition_fn_without_min_or_max_raises_error(
+        self,
+    ):
+        class DummyAcquisitionFn(AcquisitionFunction):
+            """Dummy acquisition function that doesn't set min or max"""
+            def __call__(self, **kwargs):
+                return np.zeros(1)
+
+        acquisition_fn = DummyAcquisitionFn(self.model)
+
+        X_s = self.ds_raw.air
+
+        with self.assertRaises(ValueError):
+            alg = GreedyAlgorithm(
+                model=self.model,
+                X_t=X_s,
+                X_s=X_s,
+                N_new_context=2,
+            )