Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve font colour selection #4

Open
jack89roberts opened this issue Oct 23, 2019 · 1 comment
Open

Improve font colour selection #4

jack89roberts opened this issue Oct 23, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@jack89roberts
Copy link
Collaborator

The function for selecting whether black or white text should be used over a background colour seems to work well in almost all cases, with one key exception being pure green where white is suggested but black would work better (in my opinion).
@jack89roberts jack89roberts added the enhancement New feature or request label Oct 23, 2019
@jack89roberts
Copy link
Collaborator Author

See updated comment in https://stackoverflow.com/a/3943023 (first equation is what's used in distinctipy) about the W3C recommendation for this.

@jack89roberts jack89roberts mentioned this issue Jan 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jack89roberts