-
Notifications
You must be signed in to change notification settings - Fork 1
Add support for minio copy workflow though API #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
awalford16
wants to merge
12
commits into
main
Choose a base branch
from
api/minio-data-copy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
df8f71f
add funcs for copying data from minio to workflows
awalford16 1d60a39
add minio-copy template and update api to trigger workflow
awalford16 717baf3
update move api to post request
awalford16 f308725
just repond with json
awalford16 60bf7aa
update pvc mounts in workflow template and add mc cp logic
awalford16 324e28a
deploy workflowtemplate through pulumi
awalford16 1e8cc65
clean up and formatting
awalford16 2a3cd57
remove unused imports
awalford16 e612219
template in pvc name for workflowtemplate
awalford16 eea6ffa
conditionally update the pvc name
awalford16 5d72b49
Fix linting issues
craddm adb92cc
Merge branch 'main' into api/minio-data-copy
craddm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -206,7 +206,7 @@ def __init__( | |
| name="token-vol", | ||
| mount_path="/service-account", | ||
| read_only=True, | ||
| ) | ||
| ), | ||
| ], | ||
| ) | ||
| ], | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| --- | ||
| apiVersion: argoproj.io/v1alpha1 | ||
| kind: WorkflowTemplate | ||
| metadata: | ||
| name: minio-data-copy | ||
| namespace: argo-workflows | ||
| spec: | ||
| entrypoint: pull-data-from-minio | ||
| templates: | ||
| - name: pull-data-from-minio | ||
| inputs: | ||
| parameters: | ||
| - name: bucket | ||
| - name: file | ||
| volumes: | ||
| - name: workflow-data-ingress | ||
| persistentVolumeClaim: | ||
| claimName: replace_me | ||
| container: | ||
| name: mc | ||
| image: minio/mc:latest | ||
| command: ["/bin/sh", "-c"] | ||
| args: | ||
| - | | ||
| mc --insecure alias set artifacts http://minio.argo-artifacts.svc.cluster.local $MINIO_ACCESS_KEY $MINIO_SECRET_KEY | ||
| mc cp artifacts/{{inputs.parameters.bucket}}/{{inputs.parameters.file}} /data/ | ||
| env: | ||
| - name: MC_CONFIG_DIR | ||
| value: /tmp/.mc | ||
| - name: MINIO_ACCESS_KEY | ||
| valueFrom: | ||
| secretKeyRef: | ||
| name: argo-artifacts-minio | ||
| key: accesskey | ||
| - name: MINIO_SECRET_KEY | ||
| valueFrom: | ||
| secretKeyRef: | ||
| name: argo-artifacts-minio | ||
| key: secretkey | ||
| volumeMounts: | ||
| - name: workflow-data-ingress | ||
| mountPath: /data |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#140 is now in