Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQUEST] Consider replacing seaborn confusion matrices by ConfusionMatrixDisplay #259

Open
KristinaUlicna opened this issue Sep 22, 2023 · 0 comments
Open

[FEATURE REQUEST] Consider replacing seaborn confusion matrices by ConfusionMatrixDisplay #259

KristinaUlicna opened this issue Sep 22, 2023 · 0 comments
Labels
visualisation Visualise the data I/O, training progress or properties
Milestone
Merge `dev` -> `m...

Comments

@KristinaUlicna
Copy link
Collaborator

What's the reasoning behind this, @chris-soelistyo ?

grace/grace/evaluation/metrics_classifier.py

Lines 64 to 74 in bd91bdf

# Store confusion matrices:
df_node = pd.DataFrame(
cm_node,
index=node_classes,
columns=node_classes,
)
df_edge = pd.DataFrame(
cm_edge,
index=edge_classes,
columns=edge_classes,
)

Why not just use the ConfusionMatrixDisplay method from sklearn?

https://github.com/scikit-learn/scikit-learn/blob/55a65a2fa5653257225d7e184da3d0c00ff852b1/sklearn/metrics/_plot/confusion_matrix.py#L11-L12
@KristinaUlicna KristinaUlicna added the enhancement New feature or request label Sep 22, 2023
@KristinaUlicna KristinaUlicna self-assigned this Oct 12, 2023
@KristinaUlicna KristinaUlicna added visualisation Visualise the data I/O, training progress or properties and removed enhancement New feature or request labels Oct 12, 2023
@KristinaUlicna KristinaUlicna added this to the Merge `dev` -> `main` milestone Oct 12, 2023
@KristinaUlicna KristinaUlicna removed their assignment Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
visualisation Visualise the data I/O, training progress or properties
Projects
None yet
Milestone
Merge `dev` -> `main`
Development

No branches or pull requests
1 participant
@KristinaUlicna