Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Allow user to specify control which / how many edge properties they want #319

Open
KristinaUlicna opened this issue Oct 13, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@KristinaUlicna
Copy link
Collaborator

  • Currently, the codebase restricts to use only properties in EdgeProps.
  • Extend to as many as desired with a new config hyperparameter.

grace/grace/base.py

Lines 93 to 106 in d066e4f

@enum.unique
class EdgeProps(str, enum.Enum):
"""Ordered list of edge properties to be used for classifier training."""
EDGE_LENGTH = "edge_length_nrm"
EDGE_ORIENT = "edge_orient_rad"
EAST_NEIGHBOUR_LENGTH = "east_to_mid_length_nrm"
WEST_NEIGHBOUR_LENGTH = "west_to_mid_length_nrm"
EAST_NEIGHBOUR_ORIENT = "east_to_mid_orient_rad"
WEST_NEIGHBOUR_ORIENT = "west_to_mid_orient_rad"
EAST_TRIANGLE_AREA = "east_triangle_area_nrm"
WEST_TRIANGLE_AREA = "west_triangle_area_nrm"
EAST_DISTANCE = "east_to_mid_length_rel"
WEST_DISTANCE = "west_to_mid_length_rel"

@KristinaUlicna KristinaUlicna added the enhancement New feature or request label Oct 13, 2023
@KristinaUlicna KristinaUlicna added this to the Merge `dev` -> `main` milestone Oct 13, 2023
@KristinaUlicna KristinaUlicna self-assigned this Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant