Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Pandas names for Pandas datatypes #117

Open
2 tasks
rolyp opened this issue Oct 7, 2020 · 0 comments
Open
2 tasks

Use Pandas names for Pandas datatypes #117

rolyp opened this issue Oct 7, 2020 · 0 comments
Assignees

Comments

@rolyp
Copy link
Collaborator

rolyp commented Oct 7, 2020

The current system for naming types is overly complex: each type has an internal name (e.g. "integer") and an associated PFSM. We then separately have a map (twice – see #68) between internal names and Pandas names. This is confusing and leads to weirdness like show_schema showing the inferred type as “integer” but df.types showing Int64.

  • Schema.transform suggests that date-iso-8601, date-eu and date-non-std can all be converted automatically to datatime64 by Series.astype – is this correct?
  • ptype_pandas_mapping is defined more than once
@rolyp rolyp self-assigned this Oct 7, 2020
@rolyp rolyp mentioned this issue Oct 7, 2020
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant