Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address dependency problems caused by M1 Macs #330

Closed
edwardchalstrey1 opened this issue Sep 29, 2022 · 4 comments
Closed

Address dependency problems caused by M1 Macs #330

edwardchalstrey1 opened this issue Sep 29, 2022 · 4 comments
Labels
bug Something isn't working
Milestone

Comments

@edwardchalstrey1
Copy link
Contributor

edwardchalstrey1 commented Sep 29, 2022

From a scivision workshop this week we encountered the following issues, a couple of notes on problems encountered yesterday when they were going through the example notebook, all on M1 Macs:

  • we already mentioned the tensorflow one, but to clarify a bit, if they see the error when doing load_pretrained_model for the "resnet" model, we had to clone the repo https://github.com/alan-turing-institute/scivision_classifier.git then remove tensorflow from requirements.txt, and then pip install . (and install tensorflow some other way e.g. via conda
  • some people also had problems with load_pretrained_model for the huggingface classifier. For this, the approach was similar: clone the repo https://github.com/alan-turing-institute/scivision_huggingface, remove all the "transformer" lines from the requirements.txt, then do pip install git+https://github.com/huggingface/transformers (i.e. install from source), and then do pip install . .
@edwardchalstrey1 edwardchalstrey1 changed the title Address dependency problems caused by tensorflow, transformers Address dependency problems caused by M1 Macs Sep 29, 2022
@edwardchalstrey1 edwardchalstrey1 added the bug Something isn't working label Sep 29, 2022
@edwardchalstrey1
Copy link
Contributor Author

edwardchalstrey1 commented Sep 29, 2022

I'm not sure if this is something that can be fixed by fixing the version numbers of tensorflow or transformers - we should investigate

some investigation: https://github.com/AoifeHughes/scivision_classifier/blob/requirements-fix/requirements.txt

@edwardchalstrey1
Copy link
Contributor Author

edwardchalstrey1 commented Sep 29, 2022

Since the issue doesn't occur when installing tensorflow via conda, this might be a nice time to think about updating scivision load_pretrained_model function to install dependencies for models that have an environment.yml -> #331

@edwardchalstrey1
Copy link
Contributor Author

@ots22
Copy link
Member

ots22 commented Aug 29, 2023

Closing, but linking the discussion from #444

@ots22 ots22 closed this as completed Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants