Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CLI with traits and into separate crate #79

Closed
6 tasks done
sgreenbury opened this issue Mar 30, 2023 · 3 comments
Closed
6 tasks done

Refactor CLI with traits and into separate crate #79

sgreenbury opened this issue Mar 30, 2023 · 3 comments

Comments

@sgreenbury
Copy link
Collaborator

sgreenbury commented Mar 30, 2023

Refactor the Trustchain CLI given #72:

@sgreenbury
Copy link
Collaborator Author

sgreenbury commented Jun 9, 2023

  • Comment out todo methods of the API
  • Consideer whether to remove trustchain-api dep on trustchain-ion given currently GUI and mobile implementations. If no trustchain-ion dep in trustchain-api crate, would need to:
    • Trait without default impl
    • Impl separately in CLI and FFI crates for local structs?

@sgreenbury
Copy link
Collaborator Author

Following consideration, trustchain-api remains downstream of trustchain-ion. Reconsider in further API refinements associated with #37.

sgreenbury added a commit that referenced this issue Jul 31, 2023
Revise workspace structure adding API, CLI and FFI crates (#79)
@sgreenbury
Copy link
Collaborator Author

Closing with #80 merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant