Fix rticks(), rtickformat(), rticklabels() and rtickangle() being ignored #356
Conversation
I'm not sure I understand this sentence. Would you have an example? Obs: would you mind using conventional commits and present tense? That allows commits to be properly incorporated into the changelog. Ex: In other projects I did include https://github.com/alandefreitas/futures/blob/7442a3cb0e20ce86f280f24e83f1b0bc478b2d04/.github/workflows/build.yml#L131-L133 but matplot++ doesn't have that. |
j0hnnybash
force-pushed
the
fix_rtick_functions
branch
from
9f52264
to
3e55121
Compare
Reading my own comment back, I realize it's neither understandable not grammatically correct... I'll try to come up with some examples (also for the documentation) based on my test code. |
|
Oh... you included complete examples. :) I meant just small inline examples of what you mean in the PR. The new examples are fine, but they require new images for the docs, etc... But I think I get the point now. |
Uh-oh |
|
Maybe I should dumb down the example... Okay, apparently |
Yes. It's common for some STL features never to get really implemented depending on the demand for them. The C++ garbage collector got approved and deprecated without ever being really implemented by anyone.
You can remove the examples if you want. We just needed them for the discussion here. If we're keeping these examples, we need to add them to README.md so they can be picked up by the documentation generator. |
j0hnnybash
force-pushed
the
fix_rtick_functions
branch
from
020001b
to
3e55121
Compare
|
Sorry for taking so long. I've removed the examples, hopefully I'll get around to properly integrate some of them some other time. |
|
Could you please rebase this PR on top of master or develop? The PR is now behind these branches because there has been a release. |
Context: For polar plots the (unsightly, and unhelpful) r-axis is
hidden by default, instead the grid is enabled by default.
Thus handle rticks(), rtickformat(), rticklabels() and rtickangle()
and generate the corresponding gnuplot commands even when the r-axis
is hidden.
Additionally, handle `rticks({})` and `rticklabels({})` properly by
essentially setting `rtickformat("")`, this ensures that labels are
hidden without having to disable the grid.
j0hnnybash
force-pushed
the
fix_rtick_functions
branch
from
3e55121
to
9cd64e7
Compare
|
FYI: I rebased onto master. |
Great! Thanks! |
The
rtick*group of functions previously had no effect unless the the r-axis was manually made visible. The r-axis is invisible by default and instead the major grid is enabled by default (which is much more helpful for polar plots), however this had the undesirable fact that code block that handles the*tick*()functions for arbitrary axis would not be executed.Another related issue which is also fixed by this change is that both
ax->rticklabels({});andax->rticks({});would not hide the tick labels, since hiding tick labels without also hiding the grid requires special handling.