You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As I mentioned in #28 this test was failing even before my modifications and since it's breaking the build of my pull request I decide to dig around a little.
I've inspected the the temporary PDF files generated during the test with evince and both Some Header and Some Footer are clearly present in the result. So it looks like the current test for header/footer started throwing false negatives.
I've tried finding the dependency that caused this change by downgrading both node and some of the packages to the ones used in the successful build without success. But since I am not aware of an automated way to perform such checks I ended up doing it manually so it's possible that I missed a package.
The text was updated successfully, but these errors were encountered:
This is due to the rendering differences from phantomjs. On linux it seems as though the pdf created has text in it and on osx it is just a big image - ariya/phantomjs#10373
As I mentioned in #28 this test was failing even before my modifications and since it's breaking the build of my pull request I decide to dig around a little.
The error is triggered by these two lines:
I've inspected the the temporary PDF files generated during the test with
evince
and bothSome Header
andSome Footer
are clearly present in the result. So it looks like the current test for header/footer started throwing false negatives.I've tried finding the dependency that caused this change by downgrading both node and some of the packages to the ones used in the successful build without success. But since I am not aware of an automated way to perform such checks I ended up doing it manually so it's possible that I missed a package.
The text was updated successfully, but these errors were encountered: