Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI is downloaded into artifacts folder #12

Open
wouterroos opened this issue Mar 6, 2018 · 0 comments · May be fixed by #13
Open

CLI is downloaded into artifacts folder #12

wouterroos opened this issue Mar 6, 2018 · 0 comments · May be fixed by #13

Comments

@wouterroos
Copy link

wouterroos commented Mar 6, 2018

Comment from Etienne Maheu copied from the VSTS Marketplace Q&A page:

Hello,

All the debugging we did this week made me notice an other small issue with your extension. You download the resharper cli nuget package straight in the artifact directory. This means that if no other task wipe the content of the directory after yours run, the publish artifact task will end up publishin the nuget packge.

I think a simple fix could be to download it in the source directory, though this might also cause issues for tasks that copies all nupkg files to the artifact directory later. At least, it wouldn't be there by default.

A better fix would be to do something similar to the "Use NuGet" task which stores its files in the tools folder, outside of the build directory. This is a bigger change because you will also have to consider than the file might stay there across build so it will impact how the package gets updated.

Anyway, just my two cents. It would be really appreciated if you could look into this.

I also see this behavior, and it slows down my builds significantly, would be really great if this can be fixed.

Anyway, thanks for the great work so far!

Regards,

Wouter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants