From f15923cd513a28adebc9133c815c8ad9ec21a265 Mon Sep 17 00:00:00 2001
From: Alberto Del Buono Paolini <alberto.delbuonopaolini@stud.unifi.it>
Date: Fri, 24 May 2024 16:16:47 +0200
Subject: [PATCH] Updated windows build action docs

---
 .github/workflows/linux.yml   | 4 ++--
 .github/workflows/windows.yml | 6 +++---
 README.md                     | 7 ++++---
 3 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/linux.yml b/.github/workflows/linux.yml
index 6211a0f..b995a5f 100644
--- a/.github/workflows/linux.yml
+++ b/.github/workflows/linux.yml
@@ -1,4 +1,4 @@
-name: Build Desktop App (Linux)
+name: Build Desktop App (Linux - deb)
 
 on:
   # push:
@@ -66,4 +66,4 @@ jobs:
         uses: actions/upload-artifact@v4
         with:
           name: linux
-          path: dist/bundle/appimage/**/*
+          path: dist/bundle/deb/**/*
diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml
index c66403a..da77b7f 100644
--- a/.github/workflows/windows.yml
+++ b/.github/workflows/windows.yml
@@ -1,9 +1,9 @@
 name: Build Desktop App (Windows)
 
 on:
-  # push:
-  #   branches:
-  #     - master
+  push:
+    branches:
+      - master
   # pull_request:
   #   branches:
   #     - master
diff --git a/README.md b/README.md
index 4b093fc..fb9ba97 100644
--- a/README.md
+++ b/README.md
@@ -173,10 +173,11 @@ DATABASE_URL
 - To deploy the web app using Github Pages you have to choose in the repository settings under Pages the `gh-pages` branch. You should also set workflow permissions under the Actions settings to `Read and write permissions`.
 - Change the `base_path` in the `Dioxus.pages.toml` file to match the name of your repository.
 - Remember to deploy your api with `APP_URL` set to your Github Pages domain (e.g. `https://albbus-stack.github.io`) otherwise there will be CORS errors.
-- Configure the `.github/workflows/deploy-web.yaml` workflow to deploy on every push to the `main` branch or manually with the `workflow_dispatch` event.
+- Configure the `.github/workflows/deploy-web.yaml` workflow to deploy on every push to the `master` branch or manually with the `workflow_dispatch` event.
 
 ### Desktop
 
-> Github actions for the Windows, Linux and MacOS platforms are not yet functioning since `dx bundle` fails with various errors.
+> Github actions for the Linux and MacOS platforms are not yet functioning since `dx bundle` fails with various errors.
 
-- Currently `dx bundle` is being actively developed and is not yet ready for production use, so you should use `dx build` if bundling fails (this is not good since you need attach the `dist` folder to your release to include your assets).
+- For Windows you can configure the `.github/workflows/windows.yaml` workflow to build and upload the `.msi` installer in the action artifacts on every push to the `master` branch or manually with the `workflow_dispatch` event.
+- Currently `dx bundle` is being actively developed and is not yet ready for production use, so you should use `dx build` if bundling fails on other platforms (this is not good since you need attach the entire `dist` folder to your release build).