Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PitchClass.resolveSpelling should return the Note with the closest accidental #50

Open
albertms10 opened this issue Apr 14, 2023 · 0 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@albertms10
Copy link
Owner

albertms10 commented Apr 14, 2023

Affected code

// TODO(albertms10): return the note with the closest accidental #50.
.sorted(
(a, b) => a.accidental.semitones
.abs()
.compareTo(b.accidental.semitones.abs()),
)

Failing tests

Note

Addressed in #88.

expect(const KeySignature(10, Accidental.sharp).tonalities, {
const Tonality(Note.aSharp, Modes.major),
// TODO(albertms10): Failing test #50:
// Should be `Note(Notes.f, Accidental.doubleSharp)`.
const Tonality(Note.g, Modes.minor),
});

@albertms10 albertms10 added the bug Something isn't working label Apr 14, 2023
@albertms10 albertms10 self-assigned this Apr 14, 2023
albertms10 added a commit that referenced this issue Apr 14, 2023
@albertms10 albertms10 added the help wanted Extra attention is needed label Apr 14, 2023
@albertms10 albertms10 pinned this issue Apr 14, 2023
@albertms10 albertms10 changed the title EnharmonicNote.toNote should return the Note with the closest accidental EnharmonicNote.resolveSpelling should return the Note with the closest accidental May 9, 2023
@albertms10 albertms10 added this to the Road to 0.7 milestone May 12, 2023
@albertms10 albertms10 moved this to Todo in Music notes May 13, 2023
@albertms10 albertms10 removed this from the Road to 0.7 milestone May 16, 2023
@albertms10 albertms10 unpinned this issue May 22, 2023
@albertms10 albertms10 changed the title EnharmonicNote.resolveSpelling should return the Note with the closest accidental PitchClass.resolveSpelling should return the Note with the closest accidental Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
Status: Todo
Development

No branches or pull requests

1 participant