Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5.2: VotingEscrow.sol check _moveAllDelegates for infinite loop (critical) #114

Open
toyv0 opened this issue Mar 30, 2023 · 2 comments
Open

5.2: VotingEscrow.sol check _moveAllDelegates for infinite loop (critical) #114

toyv0 opened this issue Mar 30, 2023 · 2 comments
Assignees
@toyv0
Labels
CRITICAL

Comments

@toyv0
Copy link
Contributor

toyv0 commented Mar 30, 2023 •
edited
Loading

could potentially create two storage pointers
determine if new checkpoint should be written or if the old one should be modified within the same block
@toyv0
Copy link
Contributor Author

toyv0 commented Mar 31, 2023

test to make sure you can't have two of the same checkpoint ids

@toyv0 toyv0 changed the title DAO: VotingEscrow.sol check _moveAllDelegates for infinite loop DAO: VotingEscrow.sol check _moveAllDelegates for infinite loop (critical) Apr 5, 2023
@toyv0
Copy link
Contributor Author

toyv0 commented Apr 5, 2023 •
edited
Loading

Image

@toyv0 toyv0 changed the title DAO: VotingEscrow.sol check _moveAllDelegates for infinite loop (critical) 5.1, 5.41, 5.43: VotingEscrow.sol check _moveAllDelegates for infinite loop (critical) Apr 5, 2023
@toyv0 toyv0 changed the title 5.1, 5.41, 5.43: VotingEscrow.sol check _moveAllDelegates for infinite loop (critical) 5.2, 5.42, 5.44: VotingEscrow.sol check _moveAllDelegates for infinite loop (critical) Apr 13, 2023
@toyv0 toyv0 self-assigned this Apr 24, 2023
@toyv0 toyv0 changed the title 5.2, 5.42, 5.44: VotingEscrow.sol check _moveAllDelegates for infinite loop (critical) 5.2, 5.42: VotingEscrow.sol check _moveAllDelegates for infinite loop (critical) Apr 24, 2023
@toyv0 toyv0 changed the title 5.2, 5.42: VotingEscrow.sol check _moveAllDelegates for infinite loop (critical) 5.2: VotingEscrow.sol check _moveAllDelegates for infinite loop (critical) Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@toyv0 toyv0

Labels
CRITICAL
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thetechnocratic @toyv0