Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mistake in docs? (visualize --help) #115

Closed
sudoleg opened this issue Jul 11, 2024 · 2 comments · Fixed by #116
Closed

Mistake in docs? (visualize --help) #115

sudoleg opened this issue Jul 11, 2024 · 2 comments · Fixed by #116
Labels
bug Something isn't working

Comments

@sudoleg
Copy link
Contributor

sudoleg commented Jul 11, 2024

flags.StringVar(&opts.ExcludedNamespaces, "exclude-namespaces", "kube-system", "Comma-delimited list of namespaces to include in the visualization")

Hello folks, to my understanding, the --exclude-namespaces option exculdes namespaces from visualization. However, the output of the visualuze --help command says that it's a "Comma-delimited list of namespaces to include in the visualization (default "kube-system")". If it's indeed a mistake, I would be happy to submit a PR for fixing it :)

@gadinaor-r7 gadinaor-r7 added the bug Something isn't working label Jul 28, 2024
@gadinaor-r7
Copy link
Contributor

@sudoleg - thanks - happy to take a PR to fix the typo J

@sudoleg
Copy link
Contributor Author

sudoleg commented Jul 29, 2024

@gadinaor-r7 done :) #116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants