Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Test Coverage for packages/web3/src/signer #454

Open
polarker opened this issue Nov 21, 2024 · 19 comments · May be fixed by #474
Open

Improve Test Coverage for packages/web3/src/signer #454

polarker opened this issue Nov 21, 2024 · 19 comments · May be fixed by #474
Assignees
Labels

Comments

@polarker
Copy link
Member

This issue aims to improve the test coverage for this folder by:

  1. Identifying untested or under-tested functions and classes.
  2. Writing additional unit tests to cover edge cases and scenarios.
@khayss
Copy link

khayss commented Nov 21, 2024

Hello.
I want to take up this issue.

My Background

I'm a full-stack web3 dev. I have great experience writing tests for different projects and different languages.

Action Plan

  • Review the code base to get a good idea of all components.
  • Review the test code to see areas not covered by current tests.
  • Add more tests to cover these areas.

@jaykayudo
Copy link

Let me handle this issue!

@raizo07
Copy link

raizo07 commented Nov 21, 2024

Can I tackle this one? I'm a Software developer with over four years of experience.

I will identify the untested or under-tested functions and classes and write additional unit tests to cover edge cases and scenarios

@NueloSE
Copy link

NueloSE commented Nov 21, 2024

May I try my hand at this?

@martinvibes
Copy link

Can I take care of this issue?
i'm a frontend dev and a blockchain dev kindky assign :)

@Benjtalkshow
Copy link

Mind if I take this issue?

@mimiprosper
Copy link

I'd like to take this issue. Am a web 2 frontend developer, a smart contract developer/auditor. Software Testing & security is an area am passionate about. I have participated successfully in OD Hack task assigned to me. I have done unit testing with mocha. I have done audits for lots of smart contract projects and found vulnerabilities in public & private project.

I would improve this code base test coverage by identifying tested, under-tested classes and functions. I would also write unit test to cover edge cases. I would conclude this task in 7 days if assigned this task.

@ShantelPeters
Copy link

ShantelPeters commented Nov 21, 2024

May I take care of this?

To solve this issue,
I will first use a test coverage tool to identify untested or under-tested functions and classes.Then i will review the uncovered code to understand the edge cases and scenarios. Next i will write additional unit tests that cover these gaps, ensuring to test various inputs, boundary conditions, and error handling. Finally,i will run the tests to confirm full coverage and refactor any difficult-to-test code to improve its testability.

@SoarinSkySagar
Copy link

May I work on this issue @polarker?

I have extensive experience in Cairo and am a regular contributor at @keep-starknet-strange. I have worked on many cairo codebase test cases.

eta: 2 day

@No-bodyq
Copy link

May I try my hand at this?

@Kom02
Copy link

Kom02 commented Nov 21, 2024

Hi, My name is Kevin Obando, a full stack junior developer with 2 years of experience from Costa Rica. I am starting in this community and I want to help in this project.

@Supa-mega
Copy link

Can I contribute to this one?

@vestor-dev
Copy link

hey sir I'd like to handle this task.
i'm a frontend developer and a blockchain dev
i would really love to contribute to your project
please kindly assign :)

@od-hunter
Copy link

May I handle this issue? My experience includes html, css, react, javaScript, typescript, solidity & Cairo and I'm good with testing.

I'll use a testing framework with a coverage tool to identify untested functions, methods, and classes then analyze the report for areas with low coverage, focusing on untested branches, conditions, or methods.
I'll identify critical untested functions, edge cases, and areas with complex logic, I'll focus on conditional branches, loops, and error-handling scenarios.
I'll create test cases targeting happy Path(Validate expected outcomes with valid inputs), Edge Cases(Test boundary inputs) and Error Scenarios( Validate handling of invalid inputs or exceptions).
And then test.

Kindly assign, I'm ready to work.

@Kaminar-i
Copy link

Mind if I take this issue?
i'm new and would love to work on this

@petersdt
Copy link

I’d like to work on this.

@kfastov
Copy link
Collaborator

kfastov commented Nov 24, 2024

Hey @raizo07 ! Just checking in to see how things are progressing.
Don't hesitate to reach out if you hit any roadblocks or need clarification.

@kfastov
Copy link
Collaborator

kfastov commented Nov 25, 2024

@raizo07 Hi! Any updates?

@raizo07
Copy link

raizo07 commented Nov 26, 2024

@kfastov will send in a PR today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.