Improve contract recompilation #475
Conversation
| export async function getContractByCodeHash( | ||
| nodeProvider: NodeProvider, | ||
| codeHash: HexString | ||
| ): Promise<HexString | undefined> { |
There was a problem hiding this comment.
We need to consider 429 errors due to rate limiting, and retry a few times if 429 hits
There was a problem hiding this comment.
@Lbqds It seems this one is not resolved yet?
There was a problem hiding this comment.
It was resolved in the last commit. Since we don’t want to introduce a retry mechanism in web3, the retry on failure will be done in the cli.
|
|
||
| networks: Record<NetworkId, Network<Settings>> | ||
|
|
||
| enableDebugMode?: boolean | ||
| forceRecompile?: boolean | ||
| skipRecompileIfDeployedOnMainnet?: boolean | ||
| } | ||
|
|
||
| export const DEFAULT_CONFIGURATION_VALUES = { |
There was a problem hiding this comment.
Should we enable skipRecompileOnDeployment by default?
There was a problem hiding this comment.
I'm a bit hesitant about this because most of the contract compilation occurs during the development phase. Once the contract is deployed to the mainnet, the number of compilations should be much less.
If it's enabled by default, unnecessary checks could also be made on the mainnet during the development phase.
There was a problem hiding this comment.
Agreed. Let's not enable it by default.
packages/cli/src/project.ts
Outdated
| sourceInfos: SourceInfo[], | ||
| artifactsRootDir: string | ||
| ): Promise<string[]> { | ||
| const nodeProvider = new NodeProvider(mainnetNodeUrl ?? defaultMainnetNodeUrl) |
There was a problem hiding this comment.
Let's check NetworkID to ensure that it's mainnet. It might be other networks by accident.
packages/cli/src/project.ts
Outdated
| sourceInfos: SourceInfo[], | ||
| artifactsRootDir: string | ||
| ): Promise<string[]> { | ||
| const nodeProvider = new NodeProvider(mainnetNodeUrl ?? defaultMainnetNodeUrl) |
There was a problem hiding this comment.
It seems mainetNodeUrl won't be undefined, so this check mainnetNodeUrl ?? defaultMainnetNodeUrl may not work.
There was a problem hiding this comment.
We support both alephium.config.ts and alephium.config.js configurations. When using alephium.config.ts, the compiler will ensure that the node url is not undefined. But when using alephium.config.js, the node url may be undefined.
This PR introduces two configs to improve contract recompilation:
skipRecompileIfDeployedOnMainnet: This checks the contract code hash to ensure that if the contract has already been deployed to the mainnet, it will not be recompiled.skipRecompileContracts: Users can add contracts to this list, and all contracts in this list will not be recompiled.