Skip to content
This repository has been archived by the owner on Mar 11, 2024. It is now read-only.

Multiple dapp connections #796

Closed
polarker opened this issue Sep 13, 2023 · 2 comments · May be fixed by #802
Closed

Multiple dapp connections #796

polarker opened this issue Sep 13, 2023 · 2 comments · May be fixed by #802
Assignees
@nop33
Milestone
v2.1.6

Comments

@polarker
Copy link
Member

Right now, if a new dapp is connected, the existing dapp connection will be closed. It's not convenient sometimes. For example, a user might want to connect to DEX, dapp aggregator, trading analysis platforms at the same time.

Walletconnect supports multiple connections by default, we could add the logic code without much effort, same for the UI I guess.

Priority: not urgent from my perspective.
@nop33
Copy link
Member

nop33 commented Sep 13, 2023

I've implemented this feature on the mobile wallet side, it's still being reviewed in a PR. I'll soon port the code to the desktop wallet.

nop33 added a commit that referenced this issue Oct 17, 2023
@nop33
Manage multiple WalletConnect pairings
aa60bd3 
Closes #796
@nop33 nop33 self-assigned this Oct 17, 2023
@nop33 nop33 added this to the v2.1.6 milestone Oct 17, 2023
@nop33 nop33 mentioned this issue Oct 24, 2023
Open
@nop33
Copy link
Member

nop33 commented Nov 16, 2023

This feature is merged in the monorepo, closing.

@nop33 nop33 closed this as completed Nov 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nop33 nop33

Labels
None yet
Projects
None yet
Milestone
v2.1.6
Development

Successfully merging a pull request may close this issue.

Manage multiple WalletConnect sessions alephium/desktop-wallet
2 participants
@polarker @nop33