-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some viewport profiles in getViewportProfile are not determined correctly #691
Comments
Hi @TAKARA328 Thanks for posting this issue. It turns out this util function is not up to date with latest viewportProfile table. We will update this util function ASAP after we confirm with viewportProfile team. Thanks, |
Hi @ShenChen-Amazon Thanks for good reply. I'm looking forward to it fixed. Thanks, |
Hi @ShenChen-Amazon, |
the viewports of the echo show 15 are also missing |
Is this issue/feature-request still relevant? |
I would like you to fix it. |
I'm submitting a...
Expected Behavior
getViewportProfile()
returns the correct viewport profile.Current Behavior
When I tried it with the Alexa simulator, I got the following results.
Possible Solution
The cause is that there is an error in the conditional expression.
Modify the conditional expression and use
mode
.Add the condition of
MOBILE-LANDSCAPE-LARGE
andMOBILE-PORTRAIT-LARGE
.MOBILE-PORTRAIT-SMALL
- pixelHeightSizeGroup to 'XSMALL'
- pixelHeightSizeGroup to 'XSMALL'
MOBILE-PORTRAIT-LARGE
Modify the test case of
ViewportUtils.spec.ts
.For example
HUB-LANDSCAPE-MEDIUM
Added
mode
. Changeddpi
from 160 to 213.Steps to Reproduce (for bugs)
Context
Your Environment
Node.js and NPM Info
The text was updated successfully, but these errors were encountered: