Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to upload my version of the tool #31

Open
roxart opened this issue Jan 11, 2020 · 3 comments
Open

how to upload my version of the tool #31

roxart opened this issue Jan 11, 2020 · 3 comments

Comments

@roxart
Copy link

roxart commented Jan 11, 2020

Can someone tell me how i can upload my version of the tool in a branch here or something? I did some coding to be able to fetch all buyer data when i sell stuff so i can automatically use the addresses to pring stamps. however now in the new version something doesnt work i would like to share that code and maybe if we get it working again integrate it in the main version.

also i would like to add an option in the settings that the log shows only things over a certain value like 2 euros.

regards

@tomasjanak
Copy link
Collaborator

You can upload your code to your GitHub profile and then make a pull request. I don't think there are any special rules right now, so just make a clear description of what your contribution is about.

But since you already know that is not working yet, better just make a clean upload of your code to your GitHub profile and someone might look at it and try to merge it with the latest MKMTool version and work out the problems on your fork. Once that is done, make a pull request here.

I'm just saying in advance that I won't have the time to be that somebody for a couple months, sorry.

@roxart
Copy link
Author

roxart commented Jan 14, 2020

Hey thanks - its actually here already merged with the newest mkm tool - it was also working in the 0.6 version

maybe its a small mistake you instantly know the problem or someone else knows? Im not sure what changed since then.

https://imgur.com/a/B3TGdjM

@roxart
Copy link
Author

roxart commented Jan 14, 2020

sorry forgot the link: https://github.com/roxart/newmkmmychanges

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants