Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use $cookieStore to save prevent notifications a user has already dismissed / closed #16

Open
alexbeletsky opened this issue Feb 6, 2015 · 3 comments
Open

Use $cookieStore to save prevent notifications a user has already dismissed / closed #16

alexbeletsky opened this issue Feb 6, 2015 · 3 comments

Comments

@alexbeletsky
Copy link
Owner

Use $cookieStore to save prevent notifications a user has already dismissed / closed

  • This has a config spot in the provider (getSaveResponse, setSaveResponse)
  • Add a provider config option for the cookies prefix value
  • validate that a notification with saveResponse also has a id parameter. This was needed to find * correspond correct notifications for dismissal.
@alexbeletsky
Copy link
Owner Author

Sub-task of #15

@vikeen
Copy link

vikeen commented Feb 6, 2015

I have implemented this code in my own codebase here. I would happy to take this ticket and use my current work as a starting point for a pull request.

EDIT: Too late, I already did it 👍

@alexbeletsky
Copy link
Owner Author

Discussion took place here.

@alexbeletsky alexbeletsky mentioned this issue Feb 11, 2015
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexbeletsky @vikeen