Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some of notifications stay forever #61

Open
ggat opened this issue Sep 20, 2016 · 4 comments
Open

Some of notifications stay forever #61

ggat opened this issue Sep 20, 2016 · 4 comments

Comments

@ggat
Copy link

ggat commented Sep 20, 2016

When I show more than one notification, sometimes some of them stay forever even if hide : true. I know it might be little information but please try to reproduce. Thanks.

@kepoly
Copy link

kepoly commented Sep 20, 2016

I show multiple notifications at once and never encountered this issue, what does your code look like ?

@tonestrike
Copy link

I am having the same issue as well unfortunately. @ggat did you browserify-shim ng-notifications-bar?

@tonestrike
Copy link

I was able to solve this problem by manually setting a hide value to each notification instead of setting it in the config of the app. Not ideal, but not a huge deal either.

@lextic
Copy link

lextic commented Oct 25, 2016

Experiencing the same issue.

After taking a quick look at the code, this $timeout seems to be the source of the problem; the index used in Array.splice should be computed within the body of the $timeout, or you have a guaranteed race condition when a sufficient number of notifications are shown at the same time.

There seems to be another pull request (#49) that attempts to fix this, though I haven't tested it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants