Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow nested repositories #203

Open
buschtoens opened this issue Aug 22, 2017 · 1 comment
Open

Allow nested repositories #203

buschtoens opened this issue Aug 22, 2017 · 1 comment
Labels
help wanted

Comments

@buschtoens
Copy link

buschtoens commented Aug 22, 2017 •
edited
Loading

GitLab supports arbitrarily deeply nested sub-groups, meaning that remote URLs like [email protected]:web/frontend/app.git, where web/frontend is the project and app is the repo are valid.

The regex in RemoteRevision.js#parseProjectAndRepo does not support that. Adding a third variable, the full repo path (web/frontend/app in this example), would suffice for supporting GitLab.

Are you up for a PR?
@jeffwidman jeffwidman mentioned this issue Sep 15, 2017
Merged
@alexcorre
Copy link
Owner

@buschtoens definitely up for a PR to support this feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcorre @buschtoens