Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*scs.sessionResponseWriter does not implement http.Hijacker #188

Open
NewHouses opened this issue Nov 28, 2023 · 3 comments · May be fixed by #199
Open

*scs.sessionResponseWriter does not implement http.Hijacker #188

NewHouses opened this issue Nov 28, 2023 · 3 comments · May be fixed by #199

Comments

@NewHouses
Copy link

Hey there! 👋 It seems like we've hit a small roadblock with the scs.sessionResponseWriter wrapper for http.response. Currently, it doesn't implement the http.Hijacker interface. So, when attempting to open a WebSocket, you might encounter the error message: websocket: response does not implement http.Hijacker.

In the past, it were using *scs.bufferedResponseWriter, which conveniently does implement the Hijacker interface.
@VipWW
Copy link

VipWW commented Feb 3, 2024

@alexedwards would you kindly accept pull request with a fix to this error?

@alexedwards alexedwards mentioned this issue Feb 3, 2024
Closed
@alexedwards
Copy link
Owner

alexedwards commented Feb 3, 2024 •
edited
Loading

I think that the correct fix here is really for the websocket library to start supporting http.ResponseController, which is the modern way of dealing with this.

I've pushed a38e822 which makes sessionResponseWriter implement the Hijacker and Flusher interfaces for Go 1.20+. Please let me know if it solves your problem.

@VipWW
Copy link

VipWW commented Feb 12, 2024

Thank you, works like a charm!

@alexedwards alexedwards mentioned this issue Feb 19, 2024
Closed
ryanlath added a commit to ryanlath/scs that referenced this issue Feb 19, 2024
@ryanlath
Implement http.Hijacker for sessionResponseWriter for go1.19
54046a9 
Fixes: alexedwards#188 for go1.18
@ryanlath ryanlath linked a pull request Feb 19, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement http.Hijacker for sessionResponseWriter for go1.18 ryanlath/scs
3 participants
@alexedwards @VipWW @NewHouses