Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with read.Structure for fixed SNP loci #16

Open
biodray opened this issue Jan 29, 2021 · 2 comments
Open

Problem with read.Structure for fixed SNP loci #16

biodray opened this issue Jan 29, 2021 · 2 comments

Comments

@biodray
Copy link

biodray commented Jan 29, 2021

Hi,

I have noticed a problem with the function read.Structure, which doubled the number of row of the DataMatrix (YOUR_LIST_NAME$DataMatrix) compared to the number of individuals (as in YOUR_LIST_NAME$SampleID). I have encountered this problem with a dataset in which some loci were fixed.

This problem was caused by the structure_onehot internal function, which doesn't seem to manage fixed loci (keep only 1 colum for fixed loci and double the number rows).

Now that I have noticed it I had removed fixed loci, but maybe adding a warning, or modifying the way structure_onehot works migth prevent another person from problems with this package (which, by the way, I really like!).

@alexkychen
Copy link
Owner

Hi biodray. Sorry I missed your question. Do you still encounter the same problem?

@mgdesaix
Copy link

mgdesaix commented Jun 5, 2024

Just chiming in that this is still an issue as of assignPOP version 1.3.0. Fixed states mess up the input with read.Structure, such that the resulting genetic matrix has twice the number of individuals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants