Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizr Support? #21

Open
ajbrun opened this issue Aug 2, 2017 · 0 comments
Open

Customizr Support? #21

ajbrun opened this issue Aug 2, 2017 · 0 comments

Comments

@ajbrun
Copy link

ajbrun commented Aug 2, 2017

Do you think it's worth adding customizr support, a little like:
https://github.com/andersaloof/modernizr-auto-loader

Difference being that's a loader, and this is a plugin. Therefore, it will read the actual output and create a modernizr build from it. The reason being (unless I'm misunderstanding the correct process):

  • I'm effectively creating a jquery plugin as an NPM package, which needs feature detection.
  • I therefore add Modernizr references
  • Any projects depending on my NPM package will therefore require Modernizr, but in order to create a custom build, they would need to include my package in node_modules in their file search. To me, this sounds like bad practise as I would expect anyone using my package to know to do that?

If the plugin inspected the chunk output and used customizr, then I expect this would cover any situation where either the local project had used Modernizr, or a dependency had.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant