Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set NODE_ENV in the top level of the plugin's index.js #30

Open
nerdkid93 opened this issue Sep 20, 2018 · 0 comments
Open

Don't set NODE_ENV in the top level of the plugin's index.js #30

nerdkid93 opened this issue Sep 20, 2018 · 0 comments

Comments

@nerdkid93
Copy link

There is a major undocumented side-effect that occurs with importing modernizr-webpack-plugin, namely it sets NODE_ENV to development if it's not already set.

See here for broken line.

This is a major anti-pattern. If NODE_ENV needs to be defined for the plugin to work properly, then it should set it when the plugin is constructed, and even then, it should be documented somewhere that this is happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant