fix tsconfig.json in angular demo #153
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include all *.ts files in tsconfig.json and remove the *.ios.ts and *.android.ts files that were triggering warnings. Using patterns like **/*.android.ts in "exclude" doesn't work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
When running
tns build android, there is an error:I think the error comes from the fact that the typescript file is not compiled into javascript because it is not included in tsconfig.json.
What is the new behavior?
No error.
How to reproduce?
ns --version: 7.0.11node --version: v12.21.0More info
tns build androidbefore thetns debug androidis important to avoid the problem mentioned by Android Angular demo gives error "Error: TypeError: Cannot read property 'CustomTabsIntent' of undefined" #141 (comment) aka "Application entry point file not found.".Fixes #134 #141