ResumeWithUrl does not work on IOS for Nativescipt < 7. WebView does not close on Microsoft login flow

[d1820]

Make sure to check the demo app(s) for sample usage

When trying to do the native controller auth flow with microsoft and MFA is enabled it gets stuck on the final microsoft screen and does not return to the application.

Which platform(s) does your issue occur on?

• iOS

Please, provide the following version numbers that your issue occurs with:

• CLI: 8.3.3
• Cross-platform modules: 6.6.0-next-2020-05-08-112112-01

Issue

the authState of the subcontroller is being cleared some how. and by the time it gets to resumeWithUrl its null.

I Updated the TnsOAuthLoginSubController with the following, and added better error handling

This fixed the issue on IOS, and also fixed a logout issue for Android and IOS. Hope this maybe helps someone else

    TnsOAuthLoginSubController.prototype.resumeWithUrl = function(url, completion) {
        if (platformModule.isIOS && !this.authState) { //added this check
            this.authState = new tns_oauth_auth_state_1.TnsOAuthState(this.client.codeVerifier, false, completion);
        }
        if (this.authState) {
            if (this.authState.isLogout) {
                if (url === this.client.provider.options.redirectUri || url.indexOf(this.client.provider.options.redirectUri) > -1) { //added this check
                    this.client.logout();
                    completion(undefined);
                } else {
                    completion(undefined, {
                        message: "ERROR Occurred: Url and options.redirectUri do not match",
                        url,
                        redirectUri: this.client.provider.options.redirectUri
                    });
                }
                return true;
            }
            else {
                var codeExchangeRequestUrl = this.codeExchangeRequestUrlFromRedirectUrl(url);
                if (codeExchangeRequestUrl) {
                    this.codeExchangeWithUrlCompletion(codeExchangeRequestUrl, completion);
                    return true;
                }
            }
        }
        return false;
    };