-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose Webview to allow custom config/handlers #39
Comments
Here's how I messily satisfied this need in the original nativescript-oauth plugin: alexziskind1/nativescript-oauth#58 |
The main one for me is to be able to set the navigation button back text to the same title as the previous page.
@alexziskind1 Is this something you would be happy to PR if I made options configurable? |
May we also allow config to add an activity indicator while the Webview is still loading the content and hide on pageLoadFinished?
|
Hi, I see that you closed #33 citing that "Providing a custom UI goes against the Oauth2 spec", but there are other reasons that exposing the Webview would be very useful:
webview.android.setWebChromeClient(new android.webkit.WebChromeClient());
android.getSettings().setBuiltInZoomControls(false);
android.getSettings().setUserAgentString('CUSTOM_UA_STRING');
loadStartedEvent
andloadFinishedEvent
handlersAre there other ways to accomplish the tasks above without accessing the Webview?
The text was updated successfully, but these errors were encountered: