Merge pull request #1842 from algolia/chore/MAGE-1383-codacy-3.17

cammonro · web-flow · commit 4fe2979ab9f2 · 2025-10-02T13:08:44.000-04:00
MAGE-1383 Codacy quality checks 3.17
diff --git a/.codacy.yml b/.codacy.yml
@@ -0,0 +1,5 @@
+---
+exclude_paths:
+  - ".php-cs-fixer.php"
+  - "dev/**"
+  - "Test/**"
diff --git a/Block/Adminhtml/Queue/Status.php b/Block/Adminhtml/Queue/Status.php
@@ -158,7 +158,7 @@ private function isQueueFast()
     {
         $averageProcessingTime = $this->queue->getAverageProcessingTime();
 
-        return !is_null($averageProcessingTime) && $averageProcessingTime < self::QUEUE_FAST_LIMIT;
+        return $averageProcessingTime !== null && $averageProcessingTime < self::QUEUE_FAST_LIMIT;
     }
 
     /** @return int */
diff --git a/Console/Command/Replica/ReplicaDisableVirtualCommand.php b/Console/Command/Replica/ReplicaDisableVirtualCommand.php
@@ -151,7 +151,7 @@ protected function disableVirtualReplicasForAllStores(): void
     public function removeLegacyVirtualReplicaConfig(string $scope = ScopeConfigInterface::SCOPE_TYPE_DEFAULT, int $scopeId = 0): void
     {
         $value = $this->scopeConfig->getValue(ConfigHelper::LEGACY_USE_VIRTUAL_REPLICA_ENABLED, $scope, $scopeId);
-        if (is_null($value)) {
+        if ($value === null) {
             return;
         }
         $this->output->writeln("<info>Removing legacy configuration " . ConfigHelper::LEGACY_USE_VIRTUAL_REPLICA_ENABLED . " for $scope scope" . ($scope != ScopeConfigInterface::SCOPE_TYPE_DEFAULT ? " (ID=$scopeId)" : "") . "</info>");
diff --git a/Controller/Adminhtml/IndexingManager/Reindex.php b/Controller/Adminhtml/IndexingManager/Reindex.php
@@ -149,7 +149,7 @@ protected function reindexEntities(array $entities, ?array $storeIds = null, ?ar
                 $message = $this->storeNameFetcher->getStoreName($storeId) . " ";
                 $message .= "(" . $this->indexNameFetcher->getIndexName('_' . $entity, $storeId);
 
-                if (!is_null($entityIds)) {
+                if ($entityIds !== null) {
                     $recordLabel = count($entityIds) > 1 ? "records" : "record";
                     $message .= " - " . count($entityIds) . " " . $recordLabel;
                 } else {
diff --git a/Controller/Adminhtml/Landingpage/Duplicate.php b/Controller/Adminhtml/Landingpage/Duplicate.php
@@ -26,7 +26,7 @@ public function execute()
         $landingPage = $this->landingPageFactory->create();
         $landingPage->getResource()->load($landingPage, $landingPageId);
 
-        if (is_null($landingPage)) {
+        if ($landingPage === null) {
             $this->messageManager->addErrorMessage(__('This landing page does not exists.'));
 
             return $resultRedirect->setPath('*/*/');
diff --git a/Controller/Adminhtml/Landingpage/Edit.php b/Controller/Adminhtml/Landingpage/Edit.php
@@ -10,7 +10,7 @@ class Edit extends AbstractAction
     public function execute()
     {
         $landingPage = $this->initLandingPage();
-        if (is_null($landingPage)) {
+        if ($landingPage === null) {
             $this->messageManager->addErrorMessage(__('This landing page does not exists.'));
             /** @var \Magento\Backend\Model\View\Result\Redirect $resultRedirect */
             $resultRedirect = $this->resultFactory->create(ResultFactory::TYPE_REDIRECT);
diff --git a/Controller/Adminhtml/Query/Edit.php b/Controller/Adminhtml/Query/Edit.php
@@ -10,7 +10,7 @@ class Edit extends AbstractAction
     public function execute()
     {
         $query = $this->initQuery();
-        if (is_null($query)) {
+        if ($query === null) {
             $this->messageManager->addErrorMessage(__('This query does not exists.'));
             /** @var \Magento\Backend\Model\View\Result\Redirect $resultRedirect */
             $resultRedirect = $this->resultFactory->create(ResultFactory::TYPE_REDIRECT);
diff --git a/Controller/Adminhtml/Query/Save.php b/Controller/Adminhtml/Query/Save.php
@@ -120,7 +120,7 @@ public function execute()
                 $query->getResource()->save($query);
 
                 if (isset($data['algolia_merchandising_positions']) && $data['algolia_merchandising_positions'] != ''
-                    || !is_null($data['banner_image'])) {
+                    || $data['banner_image'] !== null) {
                     $this->manageQueryRules($query->getId(), $data);
                 }
 
@@ -168,7 +168,7 @@ private function manageQueryRules(int $queryId, array $data): void
         $bannerContent = $this->prepareBannerContent($data);
 
         foreach ($stores as $storeId) {
-            if (!$positions && is_null($bannerContent)) {
+            if (!$positions && $bannerContent === null) {
                 $this->merchandisingHelper->deleteQueryRule(
                     $storeId,
                     $queryId,
diff --git a/Controller/Adminhtml/Queue/View.php b/Controller/Adminhtml/Queue/View.php
@@ -10,7 +10,7 @@ class View extends AbstractAction
     public function execute()
     {
         $job = $this->initJob();
-        if (is_null($job)) {
+        if ($job === null) {
             $this->messageManager->addErrorMessage(__('This job does not exist.'));
             /** @var \Magento\Backend\Model\View\Result\Redirect $resultRedirect */
             $resultRedirect = $this->resultFactory->create(ResultFactory::TYPE_REDIRECT);
diff --git a/Controller/Adminhtml/QueueArchive/View.php b/Controller/Adminhtml/QueueArchive/View.php
@@ -12,7 +12,7 @@ class View extends AbstractAction
     public function execute()
     {
         $job = $this->initJob();
-        if (is_null($job)) {
+        if ($job === null) {
             $this->messageManager->addErrorMessage(__('This job does not exist.'));
             /** @var Redirect $resultRedirect */
             $resultRedirect = $this->resultFactory->create(ResultFactory::TYPE_REDIRECT);
diff --git a/Helper/Adapter/FiltersHelper.php b/Helper/Adapter/FiltersHelper.php
@@ -59,7 +59,7 @@ public function getRequest()
     public function getPaginationFilters()
     {
         $paginationFilter = [];
-        $page = !is_null($this->request->getParam('page')) ?
+        $page = $this->request->getParam('page') !== null ?
             (int) $this->request->getParam('page') - 1 :
             0;
         $paginationFilter['page'] = $page;
@@ -84,7 +84,7 @@ public function getCategoryFilters($storeId)
             $categoryId = $category->getEntityId();
         }
 
-        if (!is_null($categoryId)) {
+        if ($categoryId !== null) {
             $categoryFilter['facetFilters'][] = 'categoryIds:' . $categoryId;
         }
 
@@ -234,13 +234,13 @@ public function getPriceFilters($storeId)
         $prices = [];
 
         // Instantsearch price facet compatibility
-        if (!is_null($this->request->getParam($paramPriceSlider))) {
+        if ($this->request->getParam($paramPriceSlider) !== null) {
             $pricesFilter = $this->request->getParam($paramPriceSlider);
             $prices = explode(':', $pricesFilter);
         }
 
         // Native Magento price facet compatibility
-        if (!$this->config->isInstantEnabled($storeId) && !is_null($this->request->getParam('price'))) {
+        if (!$this->config->isInstantEnabled($storeId) && $this->request->getParam('price') !== null) {
             $pricesFilter = $this->request->getParam('price');
             $prices = explode('-', $pricesFilter);
         }
diff --git a/Helper/Data.php b/Helper/Data.php
@@ -239,9 +239,9 @@ public function getIndexDataByStoreIds(): array
      */
     protected function buildIndexData(?StoreInterface $store = null): array
     {
-        $storeId = !is_null($store) ? $store->getStoreId() : null;
-        $currencyCode = !is_null($store) ?
-            $store->getCurrentCurrencyCode($storeId) :
+        $storeId = $store?->getStoreId();
+        $currencyCode = 
+            $store?->getCurrentCurrencyCode($storeId) ??
             $this->configHelper->getCurrencyCode();
 
         return [
@@ -250,7 +250,7 @@ protected function buildIndexData(?StoreInterface $store = null): array
             'indexName' => $this->getBaseIndexName($storeId),
             'priceKey' => '.' . $currencyCode . '.default',
             'facets' => $this->configHelper->getFacets($storeId),
-            'currencyCode' => $this->configHelper->getCurrencyCode($storeId),
+            'currencyCode' => $currencyCode,
             'maxValuesPerFacet' => (int) $this->configHelper->getMaxValuesPerFacet($storeId),
             'categorySeparator' => $this->configHelper->getCategorySeparator($storeId),
         ];
diff --git a/Helper/MerchandisingHelper.php b/Helper/MerchandisingHelper.php
@@ -53,11 +53,11 @@ public function saveQueryRule(int    $storeId,
             ],
         ];
 
-        if (!is_null($query) && $query != '') {
+        if ($query !== null && $query != '') {
             $condition['pattern'] = $query;
         }
 
-        if (!is_null($banner)) {
+        if ($banner !== null) {
             $rule['consequence']['userData']['banner'] = $banner;
         }
 
diff --git a/Model/Job.php b/Model/Job.php
@@ -183,7 +183,7 @@ public function getStatus(): string
     {
         $status = JobInterface::STATUS_PROCESSING;
 
-        if (is_null($this->getPid())) {
+        if ($this->getPid() === null) {
             $status = JobInterface::STATUS_NEW;
         }
 
diff --git a/Model/Observer/CatalogPermissions/CategoryPermissions.php b/Model/Observer/CatalogPermissions/CategoryPermissions.php
@@ -39,9 +39,9 @@ public function execute(Observer $observer)
             $customerGroupId = $customerGroup->getCustomerGroupId();
 
             $isVisible = (int) $this->permissionsFactory->getCatalogPermissionsHelper()->isAllowedCategoryView($storeId, $customerGroupId);
-            if (!is_null($category->getData('shared_catalog_permission_' . $customerGroupId))) {
+            if ($category->getData('shared_catalog_permission_' . $customerGroupId) !== null) {
                 $isVisible = (int) $category->getData('shared_catalog_permission_' . $customerGroupId);
-            } elseif (!is_null($category->getData('customer_group_permission_' . $customerGroupId))) {
+            } elseif ($category->getData('customer_group_permission_' . $customerGroupId) !== null) {
                 $isVisible = (int) $category->getData('customer_group_permission_' . $customerGroupId);
             }
 
diff --git a/Model/Observer/CatalogPermissions/ProductPermissions.php b/Model/Observer/CatalogPermissions/ProductPermissions.php
@@ -39,9 +39,9 @@ public function execute(Observer $observer)
             $customerGroupId = $customerGroup->getCustomerGroupId();
 
             $isVisible  = (int) $this->permissionsFactory->getCatalogPermissionsHelper()->isAllowedCategoryView($storeId, $customerGroupId);
-            if (!is_null($product->getData('shared_catalog_permission_' . $customerGroupId))) {
+            if ($product->getData('shared_catalog_permission_' . $customerGroupId) !== null) {
                 $isVisible = (int) $product->getData('shared_catalog_permission_' . $customerGroupId);
-            } elseif (!is_null($product->getData('customer_group_permission_' . $customerGroupId))) {
+            } elseif ($product->getData('customer_group_permission_' . $customerGroupId) !== null) {
                 $isVisible = (int) $product->getData('customer_group_permission_' . $customerGroupId);
             }
 
diff --git a/Model/ResourceModel/LandingPage.php b/Model/ResourceModel/LandingPage.php
@@ -136,12 +136,12 @@ public function checkUrlRewriteTable($urlKey, $storeId = null, $landingPageId =
             ->where('request_path = ?', $urlKey);
 
         // Only check a particular store if specified
-        if (!is_null($storeId) && $storeId != 0) {
+        if ($storeId) {
             $select->where('store_id = ?', $storeId);
         }
 
         // Handle the already existing url rewrite for the landing page
-        if (!is_null($landingPageId) && $landingPageId != 0) {
+        if ($landingPageId) {
             $select->where('!(entity_type = "landing-page" AND entity_id = ?)', $landingPageId);
         }
 
diff --git a/Model/ResourceModel/Query.php b/Model/ResourceModel/Query.php
@@ -29,12 +29,12 @@ public function checkQueryUnicity($queryText, $storeId = null, $queryId = null)
             ->where('query_text = ?', $queryText);
 
         // Only check a particular store if specified
-        if (!is_null($storeId) && $storeId != 0) {
+        if ($storeId !== null && $storeId != 0) {
             $select->where('store_id = ?', $storeId);
         }
 
         // Handle the already existing query text for the query
-        if (!is_null($queryId) && $queryId != 0) {
+        if ($queryId !== null && $queryId != 0) {
             $select->where('query_id != ?', $queryId);
         }
 
diff --git a/Service/AlgoliaConnector.php b/Service/AlgoliaConnector.php
@@ -135,7 +135,7 @@ protected function addAlgoliaUserAgent(int $storeId = self::ALGOLIA_DEFAULT_SCOP
      */
     public function getClient(?int $storeId = self::ALGOLIA_DEFAULT_SCOPE): SearchClient
     {
-        if (is_null($storeId)) {
+        if ($storeId === null) {
             $storeId = self::ALGOLIA_DEFAULT_SCOPE;
         }
 
@@ -477,7 +477,7 @@ protected function setLastOperationInfo(IndexOptionsInterface $indexOptions, arr
         $this->lastUsedIndexName = $indexName;
         $this->lastTaskId = $response[self::ALGOLIA_API_TASK_ID] ?? null;
 
-        if (!is_null($storeId)) {
+        if ($storeId !== null) {
             $this->lastTaskInfoByStore[$storeId] = [
                 'indexName' => $indexName,
                 'taskId' => $response[self::ALGOLIA_API_TASK_ID] ?? null
@@ -642,16 +642,16 @@ public function clearIndex(IndexOptionsInterface $indexOptions): void
      */
     public function waitLastTask(?int $storeId = null, ?string $lastUsedIndexName = null, ?int $lastTaskId = null): void
     {
-        if (is_null($lastUsedIndexName)) {
-            if (!is_null($storeId) && isset($this->lastTaskInfoByStore[$storeId])) {
+        if ($lastUsedIndexName === null) {
+            if ($storeId !== null && isset($this->lastTaskInfoByStore[$storeId])) {
                 $lastUsedIndexName = $this->lastTaskInfoByStore[$storeId]['indexName'];
             } elseif (isset($this->lastUsedIndexName)){
                 $lastUsedIndexName = $this->lastUsedIndexName;
             }
         }
 
-        if (is_null($lastTaskId)) {
-            if (!is_null($storeId) && isset($this->lastTaskInfoByStore[$storeId])) {
+        if ($lastTaskId === null) {
+            if ($storeId !== null && isset($this->lastTaskInfoByStore[$storeId])) {
                 $lastTaskId = $this->lastTaskInfoByStore[$storeId]['taskId'];
             } elseif (isset($this->lastTaskId)){
                 $lastTaskId = $this->lastTaskId;
@@ -662,7 +662,7 @@ public function waitLastTask(?int $storeId = null, ?string $lastUsedIndexName =
             return;
         }
 
-        if (is_null($storeId)) {
+        if ($storeId === null) {
             $storeId = self::ALGOLIA_DEFAULT_SCOPE;
         }
 
@@ -894,7 +894,7 @@ public function getLastTaskId(?int $storeId = null): int|null
     {
         $lastTaskId = null;
 
-        if (!is_null($storeId) && isset($this->lastTaskInfoByStore[$storeId])) {
+        if ($storeId !== null && isset($this->lastTaskInfoByStore[$storeId])) {
             $lastTaskId = $this->lastTaskInfoByStore[$storeId]['taskId'];
         } elseif (isset($this->lastTaskId)){
             $lastTaskId = $this->lastTaskId;
diff --git a/Service/Category/IndexBuilder.php b/Service/Category/IndexBuilder.php
@@ -81,7 +81,7 @@ public function buildIndex(int $storeId, ?array $entityIds, ?array $options): vo
             return;
         }
 
-        if (!is_null($entityIds)) {
+        if ($entityIds !== null) {
             $this->rebuildEntityIds($storeId, $entityIds);
             return;
         }
diff --git a/Service/IndexOptionsBuilder.php b/Service/IndexOptionsBuilder.php
@@ -82,11 +82,11 @@ protected function build(IndexOptionsInterface $indexOptions): IndexOptionsInter
      */
     protected function computeIndexName(IndexOptionsInterface $indexOptions): ?string
     {
-        if (!is_null($indexOptions->getIndexName())) {
+        if ($indexOptions->getIndexName() !== null) {
             return $indexOptions->getIndexName();
         }
 
-        if (is_null($indexOptions->getIndexSuffix())) {
+        if ($indexOptions->getIndexSuffix() === null) {
             throw new AlgoliaException('Index suffix is mandatory in case no enforced index name is specified.');
         }
 
diff --git a/Service/Product/ReplicaManager.php b/Service/Product/ReplicaManager.php
@@ -126,7 +126,7 @@ protected function getReplicaConfigurationFromAlgolia(
 
     protected function clearAlgoliaReplicaSettingCache($primaryIndexName = null): void
     {
-        if (is_null($primaryIndexName)) {
+        if ($primaryIndexName === null) {
             $this->_algoliaReplicaConfig = [];
         } else {
             unset($this->_algoliaReplicaConfig[$primaryIndexName]);
@@ -565,7 +565,7 @@ public function getUnusedReplicaIndices(int $storeId): array
 
     protected function clearUnusedReplicaIndicesCache(?int $storeId = null): void
     {
-        if (is_null($storeId)) {
+        if ($storeId === null) {
             $this->_unusedReplicaIndices = [];
         } else {
             unset($this->_unusedReplicaIndices[$storeId]);
diff --git a/Service/Product/SortingTransformer.php b/Service/Product/SortingTransformer.php
@@ -51,7 +51,7 @@ public function getSortingIndices(
     ): array
     {
         // Selectively cache this result - only cache manipulation of saved settings per store
-        $useCache = is_null($currentCustomerGroupId) && is_null($attrs);
+        $useCache = $currentCustomerGroupId === null && $attrs === null;
 
         if ($clearCache) {
             unset($this->_sortingIndices[$storeId]);
@@ -78,7 +78,7 @@ public function getSortingIndices(
             if ($this->configHelper->isCustomerGroupsEnabled($storeId) && $attr[ReplicaManagerInterface::SORT_KEY_ATTRIBUTE_NAME] === ReplicaManagerInterface::SORT_ATTRIBUTE_PRICE) {
                 $websiteId = $this->storeManager->getStore($storeId)->getWebsiteId();
                 $groupCollection = $this->groupCollection;
-                if (!is_null($currentCustomerGroupId)) {
+                if ($currentCustomerGroupId !== null) {
                     $groupCollection->addFilter('customer_group_id', $currentCustomerGroupId);
                 }
                 foreach ($groupCollection as $group) {
diff --git a/Test/Integration/Indexing/Product/Traits/ReplicaAssertionsTrait.php b/Test/Integration/Indexing/Product/Traits/ReplicaAssertionsTrait.php
@@ -130,7 +130,7 @@ protected function assertNoSortingAttribute($sortAttr, $sortDir): void
      */
     protected function mockSortUpdate(string $sortAttr, string $sortDir, array $attr, ?StoreInterface $store = null): void
     {
-        $sorting = $this->configHelper->getSorting(!is_null($store) ? $store->getId() : null);
+        $sorting = $this->configHelper->getSorting($store?->getId());
         $existing = array_filter($sorting, fn($item) => $item['attribute'] === $sortAttr && $item['sort'] === $sortDir);
 
         if ($existing) {
@@ -150,7 +150,7 @@ protected function mockSortUpdate(string $sortAttr, string $sortDir, array $attr
         $this->setConfig(
             ConfigHelper::SORTING_INDICES,
             json_encode($sorting),
-            !is_null($store) ? $store->getCode() : 'default'
+            $store?->getCode() ?? 'default'
         );
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -158,7 +158,7 @@ private function isQueueFast()`
`158`	`158`	`{`
`159`	`159`	`$averageProcessingTime = $this->queue->getAverageProcessingTime();`
`160`	`160`
`161`		`- return !is_null($averageProcessingTime) && $averageProcessingTime < self::QUEUE_FAST_LIMIT;`
	`161`	`+ return $averageProcessingTime !== null && $averageProcessingTime < self::QUEUE_FAST_LIMIT;`
`162`	`162`	`}`
`163`	`163`
`164`	`164`	`/** @return int */`
Original file line number	Diff line number	Diff line change
`@@ -151,7 +151,7 @@ protected function disableVirtualReplicasForAllStores(): void`
`151`	`151`	`public function removeLegacyVirtualReplicaConfig(string $scope = ScopeConfigInterface::SCOPE_TYPE_DEFAULT, int $scopeId = 0): void`
`152`	`152`	`{`
`153`	`153`	`$value = $this->scopeConfig->getValue(ConfigHelper::LEGACY_USE_VIRTUAL_REPLICA_ENABLED, $scope, $scopeId);`
`154`		`- if (is_null($value)) {`
	`154`	`+ if ($value === null) {`
`155`	`155`	`return;`
`156`	`156`	`}`
`157`	`157`	`$this->output->writeln("<info>Removing legacy configuration " . ConfigHelper::LEGACY_USE_VIRTUAL_REPLICA_ENABLED . " for $scope scope" . ($scope != ScopeConfigInterface::SCOPE_TYPE_DEFAULT ? " (ID=$scopeId)" : "") . "</info>");`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ class Edit extends AbstractAction`
`10`	`10`	`public function execute()`
`11`	`11`	`{`
`12`	`12`	`$landingPage = $this->initLandingPage();`
`13`		`- if (is_null($landingPage)) {`
	`13`	`+ if ($landingPage === null) {`
`14`	`14`	`$this->messageManager->addErrorMessage(__('This landing page does not exists.'));`
`15`	`15`	`/** @var \Magento\Backend\Model\View\Result\Redirect $resultRedirect */`
`16`	`16`	`$resultRedirect = $this->resultFactory->create(ResultFactory::TYPE_REDIRECT);`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ class View extends AbstractAction`
`10`	`10`	`public function execute()`
`11`	`11`	`{`
`12`	`12`	`$job = $this->initJob();`
`13`		`- if (is_null($job)) {`
	`13`	`+ if ($job === null) {`
`14`	`14`	`$this->messageManager->addErrorMessage(__('This job does not exist.'));`
`15`	`15`	`/** @var \Magento\Backend\Model\View\Result\Redirect $resultRedirect */`
`16`	`16`	`$resultRedirect = $this->resultFactory->create(ResultFactory::TYPE_REDIRECT);`
Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ class View extends AbstractAction`
`12`	`12`	`public function execute()`
`13`	`13`	`{`
`14`	`14`	`$job = $this->initJob();`
`15`		`- if (is_null($job)) {`
	`15`	`+ if ($job === null) {`
`16`	`16`	`$this->messageManager->addErrorMessage(__('This job does not exist.'));`
`17`	`17`	`/** @var Redirect $resultRedirect */`
`18`	`18`	`$resultRedirect = $this->resultFactory->create(ResultFactory::TYPE_REDIRECT);`