fix(vue): always read router callback

fixes algolia/instantsearch#6561

Author: Haroenv

vue-instantsearch/routing-vue-router/src/views/Home.vue

@@ -67,16 +67,8 @@ export default {
             }).href;
           },
           onUpdate(cb) {
-            this._onPopState = event => {
-              const routeState = event.state;
-              // at initial load, the state is read from the URL without
-              // update. Therefore the state object is not there. In this
-              // case we fallback and read the URL.
-              if (!routeState) {
-                cb(this.read());
-              } else {
-                cb(routeState);
-              }
+            this._onPopState = () => {
+              cb(this.read());
             };
             window.addEventListener('popstate', this._onPopState);
           },

vue-instantsearch/server-side-rendering/src/main.js

@@ -74,22 +74,13 @@ export async function createApp({
                 return;
               }
               // TODO: handle vue route changes
-              this._onPopState = event => {
+              this._onPopState = () => {
                 if (this.writeTimer) {
                   window.clearTimeout(this.writeTimer);
                   this.writeTimer = undefined;
                 }
 
-                const routeState = event.state;
-
-                // At initial load, the state is read from the URL without update.
-                // Therefore the state object is not available.
-                // In this case, we fallback and read the URL.
-                if (!routeState) {
-                  callback(this.read());
-                } else {
-                  callback(routeState);
-                }
+                callback(this.read());
               };
 
               window.addEventListener('popstate', this._onPopState);
@@ -119,7 +110,7 @@ export async function createApp({
       }
     },
     router,
-    render: h => h(App),
+    render: (h) => h(App),
   });
 
   const result = {

vue-instantsearch/vue3-ssr-vite/src/main.js

@@ -53,16 +53,8 @@ export function createApp({ renderToString, context } = {}) {
               return router.resolve({ query: routeState }).href;
             },
             onUpdate(callback) {
-              this._onPopState = (event) => {
-                const routeState = event.state;
-                // at initial load, the state is read from the URL without
-                // update. Therefore the state object is not there. In this
-                // case we fallback and read the URL.
-                if (!routeState) {
-                  callback(this.read());
-                } else {
-                  callback(routeState);
-                }
+              this._onPopState = () => {
+                callback(this.read());
               };
               typeof window === 'object' &&
                 window.addEventListener('popstate', this._onPopState);

vue-instantsearch/vue3-ssr-vue-cli/src/app.js

@@ -49,16 +49,8 @@ export function createApp({ renderToString, context } = {}) {
               return router.resolve({ query: routeState }).href;
             },
             onUpdate(callback) {
-              this._onPopState = event => {
-                const routeState = event.state;
-                // at initial load, the state is read from the URL without
-                // update. Therefore the state object is not there. In this
-                // case we fallback and read the URL.
-                if (!routeState) {
-                  callback(this.read());
-                } else {
-                  callback(routeState);
-                }
+              this._onPopState = () => {
+                callback(this.read());
               };
               typeof window === 'object' &&
                 window.addEventListener('popstate', this._onPopState);