Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instantsearch server-side rendering is also fetching on the client when using multi-index query in development environment #6348

Open
1 task done
chrisvltn opened this issue Sep 5, 2024 · 2 comments · Fixed by #6377
Open
1 task done

Instantsearch server-side rendering is also fetching on the client when using multi-index query in development environment #6348

chrisvltn opened this issue Sep 5, 2024 · 2 comments · Fixed by #6377
Labels
triage Issues to be categorized by the team

Comments

@chrisvltn
Copy link
Contributor

🐛 Current behavior

A client-side request to Algolia is done, even though it was already server-side rendered

🔍 Steps to reproduce

  1. Clone the repo https://github.com/chrisvltn/instantsearch-extra-fetch-issue
  2. Run pnpm dev and go to your localhost http://localhost:3000
  3. Open the browser's devtools and refresh the page.

Live reproduction

https://github.com/chrisvltn/instantsearch-extra-fetch-issue

💭 Expected behavior

No request to Algolia is done client-side when entering the page

Package version

[email protected] [email protected] [email protected]

Operating system

MacOS

Browser

Firefox

Code of Conduct

  • I agree to follow this project's Code of Conduct
@chrisvltn chrisvltn added the triage Issues to be categorized by the team label Sep 5, 2024
Haroenv added a commit that referenced this issue Sep 9, 2024
@Haroenv
fix(client): ensure client.search is bound
57dfd44 
fixes #6350
fixes algolia/algoliasearch-client-javascript#1549
possibly also solves #6348, to investigate afterwards
@Haroenv Haroenv mentioned this issue Sep 9, 2024
Merged
Haroenv added a commit that referenced this issue Sep 10, 2024
@Haroenv
fix(client): ensure client.search is bound (#6352)
2a171a9 
* fix(client): ensure client.search is bound

fixes #6350
fixes algolia/algoliasearch-client-javascript#1549
possibly also solves #6348, to investigate afterwards

* fix lint
@Roypoe
Copy link

Roypoe commented Sep 20, 2024

Hi @chrisvltn die you know if that issue was fixed by that commit below? Thx

@chrisvltn
Copy link
Contributor Author

@Roypoe The issue is still happening. I updated the libraries in the reproducible repo and it still happens :(

@shaejaz shaejaz linked a pull request Oct 25, 2024 that will close this issue
fix(instantsearch.js): fix user token not being set in time for the first query #6377
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triage Issues to be categorized by the team
Projects
None yet
Milestone
No milestone
2 participants
@chrisvltn @Roypoe