-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest release breaks some type imports #149
Comments
@codinronan What version of TypeScript are you using? Also what are your TypeScript settings for both |
@codinronan Are you able to install |
@neilcampbell apologies didn't see your messages! TS version: 4.9.5 (need to check if I can pull this forward to 5.x) I'll give your |
@neilcampbell seems I still have the issue. I have done the following:
I still see the following behavior from VSCode, however when I Command+Click on the import it does successfully take me to the file where the type is exported, for some reason: However, webpack (which is using tsc underneath, this is being built with I'm not sure what the solution is here honestly, this is arcane magic inside TS's import resolver I'd imagine... what changed from 2.3.3 to 4? Edit: adding a bit more info for you: |
@neilcampbell ok I have fixed this, I also needed to upgrade:
To their latest versions, and now it works. Seems like later versions of TS resolve imports differently and the older linting versions didn't use the newer resolver. Feel free to close, all good now! |
Release version: 4.0.0
What I'm trying to do:
Last version this worked with: 2.3.3 (I did not try the 3.x releases)
Error message received by webpack bundler using TSC as its build tool, this actually looks like an eslint error though so it's not even getting to the bundler:
And in fact I see the same error in VSCode, although the path is getting rewritten to
@algorandfoundation/algokit-utils/types/types/app-spec
I believe due to thetypesVersions
key in this project's package.jsonWhat I've tried:
types/types
path, same errorNot sure what changed, for now as a workaround I'm simply going to copy that file into my project as it's just being used for type safety in my appkit calls.
The text was updated successfully, but these errors were encountered: