Skip to content
This repository has been archived by the owner on Oct 14, 2022. It is now read-only.

Feature: Key #41

Open
tkell opened this issue Mar 22, 2016 · 3 comments
Open

Feature: Key #41

tkell opened this issue Mar 22, 2016 · 3 comments

Comments

@tkell
Copy link
Contributor

tkell commented Mar 22, 2016

I guess the parent Audio object should have a key?

Or should we be cute and make it computable per-TimeSlice?

@wxy656
Copy link

wxy656 commented Oct 13, 2016

I saw your code,and find pitch_names = [ 'c', 'c #', 'd', 'eb', 'e', 'f', 'f #', 'g' Ab ',' a ',' bb ',' b '] in audio.py file , do you use this array to match the pitch value of each beats?
So can we extracted every beat's key value directly? and the key value is equal to pitch class?

@tkell
Copy link
Contributor Author

tkell commented May 15, 2017

Hey @bmcfee, is a key estimator included in your Krema work?

@bmcfee
Copy link
Contributor

bmcfee commented May 18, 2017

Not yet, but it's on the roadmap. I'm still struggling with beats/bars, but key should be relatively easy by comparison.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants