Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dialog]support ssr please #4205

Closed
smat0096 opened this issue Dec 5, 2022 · 1 comment · Fixed by #4923
Closed

[Dialog]support ssr please #4205

smat0096 opened this issue Dec 5, 2022 · 1 comment · Fixed by #4923
Assignees
@FairyYang
Labels
💡 Feature Request New feature or request Next release issues to close in next release

Comments

@smat0096
Copy link

smat0096 commented Dec 5, 2022

Component

Dialog

Steps to reproduce

document is undefined in ssr env, at overlay.js used such code:
useListener(document, 'mousedown', clickEvent, false, !!(visible && overlayRef.current && (canCloseByOutSideClick || hasMask && canCloseByMask)));
@lakerswgq lakerswgq added the 💡 Feature Request New feature or request label Dec 5, 2022
@eternalsky eternalsky added the Next release issues to close in next release label Jul 29, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in DAILY WORK Jul 29, 2024
@FairyYang FairyYang self-assigned this Aug 19, 2024
FairyYang added a commit to FairyYang/next that referenced this issue Aug 30, 2024
@FairyYang
fix(Overlay): overlay support ssr, close alibaba-fusion#4205
8f6c856
@eternalsky eternalsky linked a pull request Aug 30, 2024 that will close this issue
fix(Overlay): overlay support SSR, close #4205 #4923
Merged
@eternalsky eternalsky moved this from 🆕 New to 👀 In review in DAILY WORK Aug 30, 2024
FairyYang added a commit to FairyYang/next that referenced this issue Sep 3, 2024
@FairyYang
fix(Overlay): overlay support ssr, close alibaba-fusion#4205
5d65ef6
FairyYang added a commit to FairyYang/next that referenced this issue Sep 4, 2024
@FairyYang
fix(Overlay): overlay support SSR, close alibaba-fusion#4205
f70ca80
FairyYang added a commit to FairyYang/next that referenced this issue Sep 5, 2024
@FairyYang
fix(Overlay): overlay support SSR, close alibaba-fusion#4205
3750dc9
FairyYang added a commit to FairyYang/next that referenced this issue Sep 5, 2024
@FairyYang
fix(Overlay): overlay support SSR, close alibaba-fusion#4205
d360cd4
eternalsky pushed a commit that referenced this issue Sep 5, 2024
@FairyYang @eternalsky
fix(Overlay): overlay support SSR, close #4205
0471a9e
@github-project-automation github-project-automation bot moved this from 👀 In review to Ready to release in DAILY WORK Sep 5, 2024
eternalsky pushed a commit that referenced this issue Sep 10, 2024
@FairyYang @eternalsky
fix(Overlay): overlay support SSR, close #4205
69241bc
@eternalsky
Copy link
Contributor

the code above is written in didMount lifeCycle, and will not affect ssr. but we review the whole code of Dialog, and fix all problems which will result in error in ssr.

@eternalsky eternalsky moved this from Ready to release to ✅ Done in DAILY WORK Sep 10, 2024
luolin-ck pushed a commit to luolin-ck/next that referenced this issue Sep 10, 2024
@FairyYang @luolin-ck
fix(Overlay): overlay support SSR, close alibaba-fusion#4205
d6f636f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FairyYang FairyYang

Labels
💡 Feature Request New feature or request Next release issues to close in next release
Projects
DAILY WORK
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(Overlay): overlay support SSR, close #4205 FairyYang/next
4 participants
@eternalsky @lakerswgq @smat0096 @FairyYang