Fix sr visitor issue. (#6245)

* Fix sr visitor issue. * Fix sr visitor issue. * Fix sr visitor issue.
alibaba · Nov 22, 2024 · 83428b9 · 83428b9
1 parent 64c4e70
commit 83428b9
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 29 deletions.
diff --git a/.../com/alibaba/druid/sql/dialect/starrocks/ast/statement/StarRocksCreateTableStatement.java b/.../com/alibaba/druid/sql/dialect/starrocks/ast/statement/StarRocksCreateTableStatement.java
@@ -9,7 +9,6 @@
 import com.alibaba.druid.sql.ast.statement.SQLSelectOrderByItem;
 import com.alibaba.druid.sql.dialect.starrocks.ast.StarRocksObject;
 import com.alibaba.druid.sql.dialect.starrocks.visitor.StarRocksASTVisitor;
-import com.alibaba.druid.sql.visitor.SQLASTVisitor;
 
 import java.util.ArrayList;
 import java.util.List;
@@ -62,17 +61,11 @@ public void setOrderBy(SQLOrderBy orderBy) {
         this.orderBy = orderBy;
     }
 
-    @Override
-    protected void accept0(SQLASTVisitor v) {
-        if (v instanceof StarRocksASTVisitor) {
-            accept0((StarRocksASTVisitor) v);
-        }
-    }
-
     @Override
     public void accept0(StarRocksASTVisitor v) {
         if (v.visit(this)) {
-            acceptChild(v);
+            acceptChild(v, engine);
+            acceptChild(v, orderBy);
         }
         v.endVisit(this);
     }

diff --git a/...src/main/java/com/alibaba/druid/sql/dialect/starrocks/visitor/StarRocksOutputVisitor.java b/...src/main/java/com/alibaba/druid/sql/dialect/starrocks/visitor/StarRocksOutputVisitor.java
@@ -50,17 +50,7 @@ protected void printEngine(SQLCreateTableStatement x) {
     }
 
     public boolean visit(StarRocksCreateTableStatement x) {
-        print0(ucase ? "CREATE " : "create ");
-        printCreateTableFeatures(x);
-        print0(ucase ? "TABLE " : "table ");
-        if (x.isIfNotExists()) {
-            print0(ucase ? "IF NOT EXISTS " : "if not exists ");
-        }
-        printTableSourceExpr(
-                x.getTableSource()
-                        .getExpr());
-        printCreateTableAfterName(x);
-        printTableElements(x.getTableElementList());
+        printCreateTable(x, false);
         printEngine(x);
         printUniqueKey(x);
         printComment(x.getComment());
@@ -72,16 +62,13 @@ public boolean visit(StarRocksCreateTableStatement x) {
         return false;
     }
 
+    @Override
     public boolean visit(SQLCreateTableStatement x) {
-        printCreateTable(x, false);
-        printEngine(x);
-        printComment(x.getComment());
-        printPartitionBy(x);
-        printDistributedBy(x);
-        printOrderBy(x);
-        printTableOptions(x);
-        printSelectAs(x, true);
-        return false;
+        if (x instanceof StarRocksCreateTableStatement) {
+            return visit((StarRocksCreateTableStatement) x);
+        } else {
+            return super.visit(x);
+        }
     }
     protected void printCreateTable(SQLCreateTableStatement x, boolean printSelect) {
         print0(ucase ? "CREATE " : "create ");