Improve oracle schema statistics #6252
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhengguanLi
commented
Nov 26, 2024
| // skip | ||
| } else { | ||
| this.visit(ident); | ||
| } |
There was a problem hiding this comment.
Avoid treating the exception name as a column
ZhengguanLi
commented
Nov 26, 2024
| @@ -528,8 +580,7 @@ public boolean visit(OracleExecuteImmediateStatement x) { | |||
| SQLExpr valueExpr = null; | |||
| if (x.getParent() instanceof SQLBlockStatement) { | |||
| List<SQLStatement> statementList = ((SQLBlockStatement) x.getParent()).getStatementList(); | |||
| for (int i = 0, size = statementList.size(); i < size; ++i) { | |||
| SQLStatement stmt = statementList.get(i); | |||
| for (SQLStatement stmt : statementList) { | |||
There was a problem hiding this comment.
Update to enhanced for loop
ZhengguanLi
commented
Nov 26, 2024
| @@ -861,8 +861,6 @@ public DbType getDbType() { | |||
| } | |||
|
|
|||
| protected Column getColumn(SQLExpr expr) { | |||
| final SQLExpr original = expr; | |||
|
|
|||
There was a problem hiding this comment.
Clean up unused variable
ZhengguanLi
commented
Nov 26, 2024
| @@ -357,7 +357,7 @@ public static long hashCode64(String owner, String name) { | |||
| return hashCode; | |||
| } | |||
|
|
|||
| public static interface Constants { | |||
| public interface Constants { | |||
There was a problem hiding this comment.
Inner interface does not need to be static(IDE warning)
ZhengguanLi
commented
Nov 26, 2024
| " ELSE" + | ||
| " DBMS_OUTPUT.PUT_LINE ('No department number ' || dept_no);" + | ||
| " DBMS_OUTPUT.PUT_LINE ('No department number');" + |
There was a problem hiding this comment.
Fix SQL syntax: dept_no is not a declared variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
IF SQL%FOUND,IF SQL%NOTFOUNDetc...whenclause:WHEN NO_DATA_FOUND,WHEN TOO_MANY_ROWSetc