Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Clarity and Log Level of Shutdown Message in HttpClientBeanHolder #12946

Open
SoilChang opened this issue Dec 16, 2024 · 1 comment
Open
Labels
area/Client Related to Nacos Client SDK contribution welcome kind/enhancement Category issues or prs related to enhancement.

Comments

@SoilChang
Copy link

Is your feature request related to a problem? Please describe.
In the HttpClientBeanHolder class, the shutdown method logs the message "Destruction of the end" at a WARN level. The text is unclear and can confuse developers about the actual state or purpose of this log entry. It also seems inappropriate to log this at the WARN level when it may be more suitable for INFO or DEBUG.

Describe the solution you'd like
Update the log message "Destruction of the end" to a clearer and more descriptive text, such as "HttpClient shutdown process completed successfully." Additionally, log this message at the INFO level since it is a standard completion notification, not a warning.

Describe alternatives you've considered

Keep the log level at WARN but improve the message clarity.
Provide an option to disable this log message entirely through configuration.

Additional context
This change would improve the clarity of logs generated during shutdown processes and reduce unnecessary WARN-level messages in application logs, helping developers better understand system behavior without being misled by unclear warnings.

image

@KomachiSion KomachiSion added area/Client Related to Nacos Client SDK kind/enhancement Category issues or prs related to enhancement. contribution welcome labels Dec 16, 2024
@SoilChang
Copy link
Author

#12950

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Client Related to Nacos Client SDK contribution welcome kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

No branches or pull requests

2 participants