Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug ?] Open-Local storage volume(PVC/PV) judgment with storageclass not found. #211

Open
luokp opened this issue Apr 23, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@luokp
Copy link
Contributor

luokp commented Apr 23, 2023

Ⅰ. Issue Description

  1. The storage class used by the pvc mounted by pod has been deleted, and the pvc was not created by openlocal. When openlocal plugin is not installed in the cluster, pod restart can be normally scheduled and pvc can be successfully mounted.

  2. After deploying openlocal in the cluster, all pod scheduling needs to go through shceduler-extender. Then,pod schedule failed。

Ⅱ. Describe what happened

In the predicate phase of shcheduler-extender, StorageTypePredicate() will return an error: failed to get storage class by name. This causes pod scheduling to fail.

Ⅲ. Describe what you expected to happen

Optimize the volume judgment logic (perhaps in utils.NeedSkip()), if the pvc is not created by openlocal, then regardless of whether there is a storageclass, directly return to skip the shceduler-extender scheduling.

Ⅳ. How to reproduce it (as minimally and precisely as possible)

Ⅴ. Anything else we need to know?

Ⅵ. Environment:

  • Open-Local version:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@luokp luokp changed the title Open-Local storage volume(PVC/PV) judgment with storageclass not found. [Bug ?] Open-Local storage volume(PVC/PV) judgment with storageclass not found. Apr 23, 2023
@pangsq
Copy link

pangsq commented Aug 16, 2023

Same problem.
It should ignore "NotFound" error when getting StorageClass, because k8s can bind pvc/pv when StorageClass does no exist.
I found some related code.
https://github.com/alibaba/open-local/blob/v0.7.1/pkg/scheduler/algorithm/predicates/storage_type.go#L84
https://github.com/alibaba/open-local/blob/v0.7.1/pkg/scheduling-framework/filter.go#L55

@peter-wangxu peter-wangxu added the bug Something isn't working label Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants