Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I need LVM to specify a SSD or HDD type disk #255

Open
dxygit1 opened this issue Mar 15, 2024 · 8 comments
Open

I need LVM to specify a SSD or HDD type disk #255

dxygit1 opened this issue Mar 15, 2024 · 8 comments

Comments

@dxygit1
Copy link

dxygit1 commented Mar 15, 2024

Does the openlocal lvm type support specifying mediaType
I need LVM to specify a SSD or HDD type disk

for example

apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
  name: lvm-xfs-ssd
{{ include "local.labels" . | indent 2 }}
provisioner: {{ .Values.driver }}
parameters:
  volumeType: "LVM"
  csi.storage.k8s.io/fstype: xfs
  mediaType: ssd
reclaimPolicy: Delete
volumeBindingMode: WaitForFirstConsumer
allowVolumeExpansion: true
@peter-wangxu
Copy link
Collaborator

LVM can combine both SSD or HDD disk into one volume group, how do you think this scinario?

say, how you konw the VG is SSD or HDD or mixed?

@dxygit1
Copy link
Author

dxygit1 commented Mar 18, 2024

Add a new storage class binding to the corresponding volume group lvm-xfs-ssd. Specify that the volume group consists entirely of SSD disks. Is this feasible?

@dxygit1
Copy link
Author

dxygit1 commented Mar 18, 2024

Would it be possible to introduce a flexible approach where any storage class starting with 'lvm-xxx' follows the same logic of binding to a volume group? I'm defining two storage classes: lvm-xxx-ssd and lvm-xxx-hdd, which will bind to different volume groups. Do you think this is feasible

@peter-wangxu
Copy link
Collaborator

sure,but we need to a rule to detect the lvm type, eg, open-local needs to detect and report the vg type in node local storage CR

@dxygit1
Copy link
Author

dxygit1 commented Mar 18, 2024

Sure, can also add a parameter similar to mediaType to specify the name of the VG. Create the corresponding VG name in NLSC.

@peter-wangxu
Copy link
Collaborator

It's reasonable to add this feature via some coding change,do you have any further thoughts on this implementation?

@dxygit1
Copy link
Author

dxygit1 commented Mar 20, 2024

I'm not very familiar with writing Go code at the moment and don't have many ideas for implementing code.

@dxygit1
Copy link
Author

dxygit1 commented Apr 1, 2024

Hello, do you have time to implement this requirement?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants