Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support warm-up flow control #39

Open
caozhiw opened this issue Jan 10, 2022 · 1 comment
Open

Support warm-up flow control #39

caozhiw opened this issue Jan 10, 2022 · 1 comment
Labels
kind/feature Category issues or prs related to feature request.

Comments

@caozhiw
Copy link

caozhiw commented Jan 10, 2022

std::shared_ptr<TrafficShapingController> FlowRuleManager::GenerateController(
    const FlowRule& rule) {
  if (rule.metric_type() == FlowMetricType::kQps) {
    switch (rule.control_behavior()) {
      case FlowControlBehavior::kWarmUp:
        // return (WarmUpCalculator, DefaultChecker);
      case FlowControlBehavior::kThrotting:
        // return (DefaultCalculator, ThrottlingChecker);
      default:
        // Default mode or unknown mode: default traffic shaping controller
        return CreateDefaultController(rule);
    }
  }
  return CreateDefaultController(rule);
}

从上面的代码来看,warm up mode 还未实现么?

@sczyh30
Copy link
Member

sczyh30 commented Jan 10, 2022

Warm-up has not been supported yet. Contributions are welcomed.

@sczyh30 sczyh30 changed the title warm up 限流还未实现,对么 Support warm-up flow control Jan 10, 2022
@sczyh30 sczyh30 added the kind/feature Category issues or prs related to feature request. label Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Category issues or prs related to feature request.
Projects
None yet
Development

No branches or pull requests

2 participants