Skip to content

Commit e323a27

Browse files
authored
Merge pull request #1870 from alicevision/dev/adaptExperimental
Upgrade experimental pipelines for better integration in Meshroom
2 parents c5b9b69 + a821297 commit e323a27

File tree

7 files changed

+151
-85
lines changed

7 files changed

+151
-85
lines changed

meshroom/aliceVision/SfmBootstraping.py renamed to meshroom/aliceVision/SfmBootstrapping.py

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
__version__ = "3.0"
1+
__version__ = "4.0"
22

33
from meshroom.core import desc
44
from meshroom.core.utils import VERBOSE_LEVEL
55

66

7-
class SfMBootStraping(desc.AVCommandLineNode):
8-
commandLine = 'aliceVision_sfmBootstraping {allParams}'
7+
class SfMBootStrapping(desc.AVCommandLineNode):
8+
commandLine = 'aliceVision_sfmBootstrapping {allParams}'
99
size = desc.DynamicNodeSize('input')
1010

1111
category = 'Sparse Reconstruction'
@@ -81,4 +81,10 @@ class SfMBootStraping(desc.AVCommandLineNode):
8181
description="Path to the output SfMData file.",
8282
value="{nodeCacheFolder}/bootstrap.abc",
8383
),
84+
desc.File(
85+
name="outputViewsAndPoses",
86+
label="Views And Poses",
87+
description="Path to the output SfMData file with cameras (views and poses).",
88+
value="{nodeCacheFolder}/cameras.sfm",
89+
)
8490
]

meshroom/cameraTrackingExperimental.mg

Lines changed: 40 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
"ImageDetectionPrompt": "0.1",
1818
"ImageMatching": "2.0",
1919
"ImageMatchingMultiSfM": "1.0",
20-
"ImageSegmentationBox": "0.1",
20+
"ImageSegmentationBox": "0.2",
2121
"KeyframeSelection": "5.0",
2222
"MeshDecimate": "1.0",
2323
"MeshFiltering": "3.0",
@@ -26,12 +26,13 @@
2626
"Publish": "1.3",
2727
"RelativePoseEstimating": "3.0",
2828
"ScenePreview": "2.0",
29-
"SfMBootStraping": "3.0",
29+
"SfMBootStrapping": "4.0",
3030
"SfMExpanding": "2.0",
3131
"SfMTransfer": "2.1",
3232
"SfMTriangulation": "1.0",
3333
"Texturing": "6.0",
34-
"TracksBuilding": "1.0"
34+
"TracksBuilding": "1.0",
35+
"TracksMerging": "3.0"
3536
},
3637
"template": true
3738
},
@@ -91,7 +92,7 @@
9192
"ConvertSfMFormat_1": {
9293
"nodeType": "ConvertSfMFormat",
9394
"position": [
94-
3800,
95+
4000,
9596
200
9697
],
9798
"inputs": {
@@ -108,7 +109,7 @@
108109
"DepthMapFilter_1": {
109110
"nodeType": "DepthMapFilter",
110111
"position": [
111-
3200,
112+
3400,
112113
0
113114
],
114115
"inputs": {
@@ -122,7 +123,7 @@
122123
"DepthMap_1": {
123124
"nodeType": "DepthMap",
124125
"position": [
125-
3000,
126+
3200,
126127
0
127128
],
128129
"inputs": {
@@ -151,7 +152,7 @@
151152
"ExportAnimatedCamera_1": {
152153
"nodeType": "ExportAnimatedCamera",
153154
"position": [
154-
2400,
155+
2600,
155156
200
156157
],
157158
"inputs": {
@@ -343,7 +344,7 @@
343344
"MeshDecimate_1": {
344345
"nodeType": "MeshDecimate",
345346
"position": [
346-
3800,
347+
4000,
347348
0
348349
],
349350
"inputs": {
@@ -357,7 +358,7 @@
357358
"MeshFiltering_1": {
358359
"nodeType": "MeshFiltering",
359360
"position": [
360-
3600,
361+
3800,
361362
0
362363
],
363364
"inputs": {
@@ -371,7 +372,7 @@
371372
"Meshing_1": {
372373
"nodeType": "Meshing",
373374
"position": [
374-
3400,
375+
3600,
375376
0
376377
],
377378
"inputs": {
@@ -389,7 +390,7 @@
389390
"PrepareDenseScene_1": {
390391
"nodeType": "PrepareDenseScene",
391392
"position": [
392-
2800,
393+
3000,
393394
0
394395
],
395396
"inputs": {
@@ -403,7 +404,7 @@
403404
"Publish_1": {
404405
"nodeType": "Publish",
405406
"position": [
406-
4200,
407+
4400,
407408
100
408409
],
409410
"inputs": {
@@ -434,7 +435,7 @@
434435
"ScenePreview_1": {
435436
"nodeType": "ScenePreview",
436437
"position": [
437-
4000,
438+
4200,
438439
200
439440
],
440441
"inputs": {
@@ -447,8 +448,8 @@
447448
"color": "#4c594c"
448449
}
449450
},
450-
"SfMBootStraping_1": {
451-
"nodeType": "SfMBootStraping",
451+
"SfMBootStrapping_1": {
452+
"nodeType": "SfMBootStrapping",
452453
"position": [
453454
1200,
454455
0
@@ -469,9 +470,9 @@
469470
0
470471
],
471472
"inputs": {
472-
"input": "{SfMBootStraping_1.output}",
473-
"tracksFilename": "{SfMBootStraping_1.tracksFilename}",
474-
"meshFilename": "{SfMBootStraping_1.meshFilename}",
473+
"input": "{SfMBootStrapping_1.output}",
474+
"tracksFilename": "{SfMBootStrapping_1.tracksFilename}",
475+
"meshFilename": "{SfMBootStrapping_1.meshFilename}",
475476
"minAngleForTriangulation": 1.0,
476477
"minAngleForLandmark": 0.5
477478
},
@@ -484,12 +485,12 @@
484485
"SfMExpanding_2": {
485486
"nodeType": "SfMExpanding",
486487
"position": [
487-
2200,
488+
2400,
488489
200
489490
],
490491
"inputs": {
491492
"input": "{TracksBuilding_2.input}",
492-
"tracksFilename": "{TracksBuilding_2.output}",
493+
"tracksFilename": "{TracksMerging_1.output}",
493494
"meshFilename": "{SfMExpanding_1.meshFilename}",
494495
"nbFirstUnstableCameras": 0,
495496
"maxImagesPerGroup": 0,
@@ -507,7 +508,7 @@
507508
"SfMTransfer_1": {
508509
"nodeType": "SfMTransfer",
509510
"position": [
510-
2400,
511+
2600,
511512
0
512513
],
513514
"inputs": {
@@ -523,7 +524,7 @@
523524
"SfMTriangulation_1": {
524525
"nodeType": "SfMTriangulation",
525526
"position": [
526-
2600,
527+
2800,
527528
0
528529
],
529530
"inputs": {
@@ -540,7 +541,7 @@
540541
"Texturing_1": {
541542
"nodeType": "Texturing",
542543
"position": [
543-
4000,
544+
4200,
544545
0
545546
],
546547
"inputs": {
@@ -591,6 +592,22 @@
591592
"internalInputs": {
592593
"color": "#80766f"
593594
}
595+
},
596+
"TracksMerging_1": {
597+
"nodeType": "TracksMerging",
598+
"position": [
599+
2200,
600+
200
601+
],
602+
"inputs": {
603+
"inputs": [
604+
"{TracksBuilding_2.output}",
605+
"{SfMExpanding_1.tracksFilename}"
606+
]
607+
},
608+
"internalInputs": {
609+
"color": "#80766f"
610+
}
594611
}
595612
}
596613
}

0 commit comments

Comments
 (0)