Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[request] environment variables #2024

Open
natowi opened this issue May 24, 2023 · 2 comments
Open

[request] environment variables #2024

natowi opened this issue May 24, 2023 · 2 comments
Labels
feature request feature request from the community

Comments

@natowi
Copy link
Member

natowi commented May 24, 2023

@almarouk I see you are working on environment variables here #2022

Not directly related, but here are a few ideas on the topic:
It would be great if we had a default folder/variable where we could drop third party executables, batch files and python scrips/ nodes in as I suggested here #2009 (comment)
Instead of having to manually setting a environmental variable

Also note that the ALICEVISION_SENSOR_DB path is not being written as variable to the mg file when saving a project, instead the full path is stored. When sharing a template with another user this can cause nodes to fail, since the path does not exist in the other system.

Finally it would be really helpful if we could define the variables globally from the GUI, this way we could add variables easily for custom nodes

@natowi natowi added the feature request feature request from the community label May 24, 2023
@cbentejac
Copy link
Contributor

Hi @natowi,

Regarding that part of your message:

Also note that the ALICEVISION_SENSOR_DB path is not being written as variable to the mg file when saving a project, instead the full path is stored. When sharing a template with another user this can cause nodes to fail, since the path does not exist in the other system.

Is this the behaviour you have with Meshroom 2023.1? If the path to the sensor database is not an hard-coded one in your project, it should be saved as ${ALICEVISION_SENSOR_DB} in the .mg file, not as the resolved path.

As for templates, only the parameters that have non-default values are saved in the .mg file. So if the path to the database is the one by default (${ALICEVISION_SENSOR_DB}) and not an hard-coded one, sharing a template should not cause any issue (the user will open it, and as the path to the database is not specified in the .mg file, the default value will be systematically used).

I just tested it on both Linux and Windows and it worked as expected, so I'm not really sure of what's happening on your side.

@natowi
Copy link
Member Author

natowi commented May 25, 2023

You are right, sorry, wrong mg file ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request feature request from the community
Projects
None yet
Development

No branches or pull requests

2 participants