Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reporting broken use when calling default parent constructor #28

Closed
lmove opened this issue Feb 24, 2022 · 2 comments
Closed

Reporting broken use when calling default parent constructor #28

lmove opened this issue Feb 24, 2022 · 2 comments
Labels
bug Something isn't working maracas-core Related to Maracas core API

Comments

@lmove
Copy link
Collaborator

lmove commented Feb 24, 2022

Maracas is wrongly reporting broken uses when calling a default parent constructor (i.e. super()). Notice that this is an issue especially when dealing with interfaces. All classes (including interfaces) in Java have default constructors. Thus, invoking the super() method is completely valid when implementing an interface. These cases are false positives.

Related broken use:

Path: path-to/maracas/test-data/comp-changes/client/src/mainclient/classNowAbstract/IClassNowAbstractExt.java
Line: 8
Breaking change: CONSTRUCTOR_REMOVED
API use: METHOD_INVOCATION
Used declaration: main.classNowAbstract.IClassNowAbstract()
Source declaration: main.classNowAbstract.IClassNowAbstract()
@lmove lmove added bug Something isn't working maracas-core Related to Maracas core API labels Feb 24, 2022
@lmove
Copy link
Collaborator Author

lmove commented Mar 1, 2022

Related to #29

@lmove
Copy link
Collaborator Author

lmove commented Mar 17, 2022

Closing this issue but must be considered when implementing the CLASS_TYPE_CHANGED and the SUPERCLASS_REMOVED visitor.

@lmove lmove closed this as completed Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maracas-core Related to Maracas core API
Projects
None yet
Development

No branches or pull requests

1 participant