From 32195104fb308c8914bd8ec7eda5e27ba4cb5dd6 Mon Sep 17 00:00:00 2001 From: Jeroen Versteeg Date: Sat, 16 Mar 2024 14:42:12 +0100 Subject: [PATCH] Add information re: comment nodes to README See https://github.com/twigphp/Twig/pull/4009 for more details --- README.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index fea661c..3270293 100644 --- a/README.md +++ b/README.md @@ -66,14 +66,15 @@ One seemingly simple is that there's no way to distinguish whether a `macro` arg an implicit one. `ExpressionParser->parseArguments()` (line 628) will create identical ASTs for both. Another is that comments are not added to the AST at all (see `Lexer->lexComment()`), making it impossible to process -type hints in `@var` comments. +type hints in `@var` comments. Support for this has been added in +[a Twig PR](https://github.com/twigphp/Twig/pull/4009). Let's 🤞 this gets merged! # Inspections Here's a list of inspections considered relevant. Those marked with ❌ are (considered) impossible to implement with the current design given the limitations. -Most, if not all, of these inspections depend on the ability to inspect comments. +Most, if not all, of these inspections depend on the ability to inspect comments, and can't be implemented *yet*. ## Variable types * ❌ Invalid type (e.g., `{# @var i nit #}`)